Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 253843002: Deprecate Attr.nodeValue / Attr.textContent (Closed)

Created:
6 years, 7 months ago by Inactive
Modified:
6 years, 7 months ago
CC:
blink-reviews, chrishtr, arv+blink, sof, eae+blinkwatch, ojan, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, eseidel, dominicc (has gone to gerrit)
Visibility:
Public.

Description

Deprecate Attr.nodeValue / Attr.textContent Deprecate Attr.nodeValue / Attr.textContent as those are no longer present in DOM: http://dom.spec.whatwg.org/#interface-attr This behavior is consistent with Firefox (confirmed with version 28), which also prints a deprecation warning when accessing those 2 properties on an Attr object. The warning message promotes the use of Attr.value instead. R=arv@chromium.org, tkent@chromium.org BUG=305105 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172803

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebaseline more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -92 lines) Patch
M LayoutTests/dom/html/level1/core/hc_attrappendchild1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrappendchild3-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrappendchild6-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrclonenode1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrcreatetextnode-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrcreatetextnode2-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attreffectivevalue-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore2-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore3-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore4-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrnormalize-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrremovechild1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrreplacechild1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrreplacechild2-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrsetvalue1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrsetvalue2-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_documentcreateattribute-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_namednodemapsetnameditemreturnvalue-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_namednodemapsetnameditemthatexists-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_nodeattributenodevalue-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrappendchild1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrappendchild3-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrappendchild6-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrclonenode1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrcreatetextnode-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrcreatetextnode2-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attreffectivevalue-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore2-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore3-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore4-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrnormalize-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrremovechild1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrreplacechild1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrreplacechild2-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrsetvalue1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrsetvalue2-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_documentcreateattribute-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_namednodemapsetnameditemreturnvalue-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_namednodemapsetnameditemthatexists-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_nodeattributenodevalue-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode01-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode02-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode21-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodegettextcontent06-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodegettextcontent07-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodesettextcontent05-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodesettextcontent06-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html View 15 chunks +22 lines, -22 lines 0 comments Download
M LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt View 12 chunks +22 lines, -21 lines 0 comments Download
M LayoutTests/fast/dom/Element/script-tests/getAttribute-check-case-sensitivity.js View 9 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/fast/dom/Node/initial-values-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Node/script-tests/initial-values.js View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/attribute-empty-value-no-children.html View 2 chunks +11 lines, -21 lines 0 comments Download
M LayoutTests/fast/dom/attribute-empty-value-no-children-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/set-attribute-in-shadow-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-iframe-src-alias.html View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-iframe-src-alias-expected.txt View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/jquery/attributes-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/resources/dump-as-markup.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Attr.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Inactive
6 years, 7 months ago (2014-04-28 17:06:14 UTC) #1
eseidel
Is usage low enough that these won't be spam?
6 years, 7 months ago (2014-04-28 17:08:27 UTC) #2
Inactive
On 2014/04/28 17:08:27, eseidel wrote: > Is usage low enough that these won't be spam? ...
6 years, 7 months ago (2014-04-28 17:15:15 UTC) #3
eseidel
lgtm I'm not sure the top 1000 is a very useful signal. I Think we ...
6 years, 7 months ago (2014-04-28 17:17:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/253843002/40001
6 years, 7 months ago (2014-04-28 17:17:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 17:36:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 7 months ago (2014-04-28 17:36:03 UTC) #7
Inactive
On 2014/04/28 17:36:03, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-04-28 17:37:53 UTC) #8
arv (Not doing code reviews)
LGTM
6 years, 7 months ago (2014-04-28 17:49:02 UTC) #9
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 7 months ago (2014-04-28 19:27:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/253843002/40001
6 years, 7 months ago (2014-04-28 19:27:51 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 20:05:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 7 months ago (2014-04-28 20:05:13 UTC) #13
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 7 months ago (2014-04-28 20:07:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/253843002/40001
6 years, 7 months ago (2014-04-28 20:07:48 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 20:43:15 UTC) #16
Message was sent while issue was closed.
Change committed as 172803

Powered by Google App Engine
This is Rietveld 408576698