Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 253843002: Deprecate Attr.nodeValue / Attr.textContent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaseline more tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 697 matching lines...) Expand 10 before | Expand all | Expand 10 after
708 708
709 case AttributeOwnerElement: 709 case AttributeOwnerElement:
710 return "'Attr.ownerElement' is deprecated and has been removed from DOM4 (http://w3.org/tr/dom)."; 710 return "'Attr.ownerElement' is deprecated and has been removed from DOM4 (http://w3.org/tr/dom).";
711 711
712 case ElementSetAttributeNodeNS: 712 case ElementSetAttributeNodeNS:
713 return "'Element.setAttributeNodeNS' is deprecated and has been removed from DOM4 (http://w3.org/tr/dom)."; 713 return "'Element.setAttributeNodeNS' is deprecated and has been removed from DOM4 (http://w3.org/tr/dom).";
714 714
715 case NodeIteratorDetach: 715 case NodeIteratorDetach:
716 return "'NodeIterator.detach' is now a no-op, as per DOM (http://dom.spe c.whatwg.org/#dom-nodeiterator-detach)."; 716 return "'NodeIterator.detach' is now a no-op, as per DOM (http://dom.spe c.whatwg.org/#dom-nodeiterator-detach).";
717 717
718 case AttrNodeValue:
719 return "'Attr.nodeValue' is deprecated. Please use 'value' instead.";
720
721 case AttrTextContent:
722 return "'Attr.textContent' is deprecated. Please use 'value' instead.";
723
718 // Features that aren't deprecated don't have a deprecation message. 724 // Features that aren't deprecated don't have a deprecation message.
719 default: 725 default:
720 return String(); 726 return String();
721 } 727 }
722 } 728 }
723 729
724 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 730 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
725 { 731 {
726 ASSERT(feature >= firstCSSProperty); 732 ASSERT(feature >= firstCSSProperty);
727 ASSERT(feature <= lastCSSProperty); 733 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
756 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 762 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
757 { 763 {
758 // FIXME: We may want to handle stylesheets that have multiple owners 764 // FIXME: We may want to handle stylesheets that have multiple owners
759 // http://crbug.com/242125 765 // http://crbug.com/242125
760 if (sheetContents && sheetContents->hasSingleOwnerNode()) 766 if (sheetContents && sheetContents->hasSingleOwnerNode())
761 return getFrom(sheetContents->singleOwnerDocument()); 767 return getFrom(sheetContents->singleOwnerDocument());
762 return 0; 768 return 0;
763 } 769 }
764 770
765 } // namespace WebCore 771 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698