Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: LayoutTests/fast/dom/attribute-empty-value-no-children.html

Issue 253843002: Deprecate Attr.nodeValue / Attr.textContent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaseline more tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/attribute-empty-value-no-children.html
diff --git a/LayoutTests/fast/dom/attribute-empty-value-no-children.html b/LayoutTests/fast/dom/attribute-empty-value-no-children.html
index d082f55479e885e5610d81819093d5d2500e206c..a855e84347447f4ed1c05b1a73354b83dc06e26f 100644
--- a/LayoutTests/fast/dom/attribute-empty-value-no-children.html
+++ b/LayoutTests/fast/dom/attribute-empty-value-no-children.html
@@ -8,8 +8,6 @@
}
function isReallyEmpty(attr) {
return attr.value === ""
- && attr.nodeValue === ""
- && attr.textContent === ""
&& attr.hasChildNodes() === false
&& attr.firstChild === null
&& attr.lastChild === null
@@ -27,40 +25,32 @@
dynamicAttr.value = "";
tests[2] = isReallyEmpty(dynamicAttr);
- dynamicAttr.textContent = "bar";
- dynamicAttr.textContent = "";
- tests[3] = isReallyEmpty(dynamicAttr);
-
var parsedAttr = document.body.getAttributeNode("id");
- tests[4] = isReallyEmpty(parsedAttr);
+ tests[3] = isReallyEmpty(parsedAttr);
parsedAttr.value = "";
- tests[5] = isReallyEmpty(parsedAttr);
+ tests[4] = isReallyEmpty(parsedAttr);
parsedAttr.value = "bar";
parsedAttr.value = "";
- tests[6] = isReallyEmpty(parsedAttr);
-
- parsedAttr.textContent = "bar";
- parsedAttr.textContent = "";
- tests[7] = isReallyEmpty(parsedAttr);
+ tests[5] = isReallyEmpty(parsedAttr);
var parsedAttrIntitiallyNonEmpty = document.body.getAttributeNode("class");
parsedAttrIntitiallyNonEmpty.value = "";
- tests[8] = isReallyEmpty(parsedAttrIntitiallyNonEmpty);
+ tests[6] = isReallyEmpty(parsedAttrIntitiallyNonEmpty);
- parsedAttrIntitiallyNonEmpty.textContent = "bar";
- parsedAttrIntitiallyNonEmpty.textContent = "";
- tests[9] = isReallyEmpty(parsedAttrIntitiallyNonEmpty);
+ parsedAttrIntitiallyNonEmpty.value = "bar";
+ parsedAttrIntitiallyNonEmpty.value = "";
+ tests[7] = isReallyEmpty(parsedAttrIntitiallyNonEmpty);
document.body.setAttribute("title", "");
var parsedAttrNodeChangedToEmptyBySetAttribute = document.body.getAttributeNode("title");
- tests[10] = isReallyEmpty(parsedAttrNodeChangedToEmptyBySetAttribute);
+ tests[8] = isReallyEmpty(parsedAttrNodeChangedToEmptyBySetAttribute);
- parsedAttrNodeChangedToEmptyBySetAttribute.textContent = "bar";
- parsedAttrNodeChangedToEmptyBySetAttribute.textContent = "";
- tests[11] = isReallyEmpty(parsedAttrNodeChangedToEmptyBySetAttribute);
+ parsedAttrNodeChangedToEmptyBySetAttribute.value = "bar";
+ parsedAttrNodeChangedToEmptyBySetAttribute.value = "";
+ tests[9] = isReallyEmpty(parsedAttrNodeChangedToEmptyBySetAttribute);
var results = document.getElementsByTagName("p")[1];
while (results.hasChildNodes()) {

Powered by Google App Engine
This is Rietveld 408576698