Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2538343002: De-flake IndexedDB layout tests. (Closed)

Created:
4 years ago by pwnall
Modified:
4 years ago
Reviewers:
jsbell
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

De-flake IndexedDB layout tests. Per the IndexedDB specification, a versionchange transaction is running until the open request's transaction member is set to null, which should happen (synchronously) after the onabort() event handler is called. Therefore, tests can only assume that a transaction stopped running after the onabort event handler has occurred. BUG=657968 Committed: https://crrev.com/c6c814b48c0ec98a495202b17ce55a0aef8364d4 Cr-Commit-Position: refs/heads/master@{#437974}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-createObjectStore-exception-order.html View 2 chunks +12 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-deleteObjectStore-exception-order.html View 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
pwnall
PTAL? I ran each test 1,000 times. My interpretation is based on S 5.7 of ...
4 years ago (2016-12-07 02:37:38 UTC) #6
jsbell
lgtm
4 years ago (2016-12-12 22:20:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538343002/20001
4 years ago (2016-12-12 23:01:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/121512) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-12 23:08:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538343002/40001
4 years ago (2016-12-12 23:51:01 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-13 01:12:08 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-13 01:16:27 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c6c814b48c0ec98a495202b17ce55a0aef8364d4
Cr-Commit-Position: refs/heads/master@{#437974}

Powered by Google App Engine
This is Rietveld 408576698