Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-deleteObjectStore-exception-order.html

Issue 2538343002: De-flake IndexedDB layout tests. (Closed)
Patch Set: Rebased. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-createObjectStore-exception-order.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-deleteObjectStore-exception-order.html
diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-deleteObjectStore-exception-order.html b/third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-deleteObjectStore-exception-order.html
index a45190c0805a34dbbbf60e0ae1d7a1158aef6cf5..b411393142dcedfde5f908113d26e87d13a76f7c 100644
--- a/third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-deleteObjectStore-exception-order.html
+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-deleteObjectStore-exception-order.html
@@ -10,15 +10,17 @@
indexeddb_test(
(t, db, req) => {
db.createObjectStore('s');
- req.transaction.abort();
+ req.transaction.onabort = () => {
+ setTimeout(t.step_func(() => {
+ assert_throws(
+ 'InvalidStateError', () => { db.deleteObjectStore('s'); },
+ '"running an upgrade transaction" check (InvalidStateError) ' +
+ 'should precede "not active" check (TransactionInactiveError)');
+ t.done();
+ }), 0);
+ };
req.onerror = null;
- setTimeout(t.step_func(() => {
- assert_throws(
- 'InvalidStateError', () => { db.deleteObjectStore('s'); },
- '"running an upgrade transaction" check (InvalidStateError) ' +
- 'should precede "not active" check (TransactionInactiveError)');
- t.done();
- }), 0);
+ req.transaction.abort();
},
(t, db) => { t.assert_unreached('open should fail'); },
'IDBDatabase.deleteObjectStore exception order: ' +
@@ -27,8 +29,8 @@ indexeddb_test(
indexeddb_test(
(t, db, req) => {
- req.transaction.abort();
req.onerror = null;
+ req.transaction.abort();
assert_throws(
'TransactionInactiveError', () => { db.deleteObjectStore('nope'); },
'"not active" check (TransactionInactiveError) should precede ' +
« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-createObjectStore-exception-order.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698