Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2538043003: Roll third_party/inspector_protocol to 715b83a3cfb45ce6c67b6c6fdd2c16391b5db896 (Closed)

Created:
4 years ago by kozy
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll third_party/inspector_protocol to 715b83a3cfb45ce6c67b6c6fdd2c16391b5db896 This roll includes: - [inspector_protocol] always use weak pointer in DispatcherImpl::{command.name} [1] [1] https://codereview.chromium.org/2545613002/ BUG=chromium:668358 TBR=dgozman@chromium.org Committed: https://crrev.com/37a85a4adb7d94f780e42155e36fc7413fd0dd9d Cr-Commit-Position: refs/heads/master@{#435535}

Patch Set 1 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/inspector_protocol/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_cpp.template View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
kozy
Dmitry, please take a look.
4 years ago (2016-12-01 00:40:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538043003/40001
4 years ago (2016-12-01 02:43:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years ago (2016-12-01 02:47:41 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-01 02:52:42 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37a85a4adb7d94f780e42155e36fc7413fd0dd9d
Cr-Commit-Position: refs/heads/master@{#435535}

Powered by Google App Engine
This is Rietveld 408576698