Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4256)

Issue 2545613002: [inspector_protocol] always use weak pointer in DispatcherImpl::{command.name} (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[inspector_protocol] always use weak pointer in DispatcherImpl::{command.name} Dispatcher can be destroyed during command processing. BUG=chromium:668358 R=dgozman@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocol715b83a3cfb45ce6c67b6c6fdd2c16391b5db896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M templates/TypeBuilder_cpp.template View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kozy
Dmitry please take a look. I checked locally that it solves an issue.
3 years, 8 months ago (2016-12-01 00:04:15 UTC) #1
dgozman
lgtm
3 years, 8 months ago (2016-12-01 00:24:52 UTC) #2
kozy
3 years, 8 months ago (2016-12-01 00:36:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
715b83a3cfb45ce6c67b6c6fdd2c16391b5db896 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698