Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: net/cert/multi_log_ct_verifier_unittest.cc

Issue 2537373002: Use different source types for each ConnectJob subclass. (Closed)
Patch Set: backwards compat Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/multi_log_ct_verifier_unittest.cc
diff --git a/net/cert/multi_log_ct_verifier_unittest.cc b/net/cert/multi_log_ct_verifier_unittest.cc
index 2efd7012a46155c25617a32e3ab6f2357d627e89..b0ae680e02d32c52a4d4f8a586ba801b84f13cea 100644
--- a/net/cert/multi_log_ct_verifier_unittest.cc
+++ b/net/cert/multi_log_ct_verifier_unittest.cc
@@ -122,8 +122,8 @@ class MultiLogCTVerifierTest : public ::testing::Test {
bool VerifySinglePrecertificateChain(scoped_refptr<X509Certificate> chain) {
SignedCertificateTimestampAndStatusList scts;
TestNetLog test_net_log;
- NetLogWithSource net_log =
- NetLogWithSource::Make(&test_net_log, NetLogSourceType::CONNECT_JOB);
+ NetLogWithSource net_log = NetLogWithSource::Make(
+ &test_net_log, NetLogSourceType::SSL_CONNECT_JOB);
mmenke 2016/11/30 15:09:24 Do these actually matter, or could you just use Ne
davidben 2016/11/30 17:37:49 This one doesn't seem to, but the one below checks
return verifier_->Verify(chain.get(), std::string(), std::string(), &scts,
net_log) == OK;
@@ -132,8 +132,8 @@ class MultiLogCTVerifierTest : public ::testing::Test {
bool CheckPrecertificateVerification(scoped_refptr<X509Certificate> chain) {
SignedCertificateTimestampAndStatusList scts;
TestNetLog test_net_log;
- NetLogWithSource net_log =
- NetLogWithSource::Make(&test_net_log, NetLogSourceType::CONNECT_JOB);
+ NetLogWithSource net_log = NetLogWithSource::Make(
+ &test_net_log, NetLogSourceType::SSL_CONNECT_JOB);
return (VerifySinglePrecertificateChain(chain, net_log, &scts) &&
ct::CheckForSingleVerifiedSCTInResult(scts, kLogDescription) &&
ct::CheckForSCTOrigin(

Powered by Google App Engine
This is Rietveld 408576698