Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/browser/resources/net_internals/source_entry.js

Issue 2537373002: Use different source types for each ConnectJob subclass. (Closed)
Patch Set: backwards compat Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/source_entry.js
diff --git a/chrome/browser/resources/net_internals/source_entry.js b/chrome/browser/resources/net_internals/source_entry.js
index e1e217b188f65a17de063dc3ad70594cd697936f..bca0e04b1103a339d665f16731377ca34995fb28 100644
--- a/chrome/browser/resources/net_internals/source_entry.js
+++ b/chrome/browser/resources/net_internals/source_entry.js
@@ -84,7 +84,13 @@ var SourceEntry = (function() {
case EventSourceType.HTTP_STREAM_JOB:
this.description_ = e.params.url;
break;
+ // TODO(davidben): Remove CONNECT_JOB after M57 is released.
case EventSourceType.CONNECT_JOB:
mmenke 2016/11/30 15:09:24 This works, even if EventSourceType.CONNECT_JOB is
davidben 2016/11/30 17:37:49 Apparently. EventSourceType.SOCKET_STREAM is also
mmenke 2016/11/30 20:51:59 But....then we'd have multiple "case -1:", instead
davidben 2016/11/30 20:58:38 Yup, works fine. JavaScript is fine with duplicate
+ case EventSourceType.TRANSPORT_CONNECT_JOB:
+ case EventSourceType.SSL_CONNECT_JOB:
+ case EventSourceType.SOCKS_CONNECT_JOB:
+ case EventSourceType.HTTP_PROXY_CONNECT_JOB:
+ case EventSourceType.WEB_SOCKET_TRANSPORT_CONNECT_JOB:
this.description_ = e.params.group_name;
break;
case EventSourceType.HOST_RESOLVER_IMPL_JOB:
« no previous file with comments | « no previous file | chrome/test/data/webui/net_internals/log_view_painter.js » ('j') | net/cert/multi_log_ct_verifier_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698