Use different source types for each ConnectJob subclass.

net/cert/multi_log_ct_verifier_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/multi_log_ct_verifier.h"
 
 #include <memory>
 #include <string>
 
 #include "base/files/file_path.h"
@@ skipping 104 matching lines @@
       scoped_refptr<X509Certificate> chain,
       const NetLogWithSource& net_log,
       SignedCertificateTimestampAndStatusList* output_scts) {
     return verifier_->Verify(chain.get(), std::string(), std::string(),
                              output_scts, net_log) == OK;
   }
 
   bool VerifySinglePrecertificateChain(scoped_refptr<X509Certificate> chain) {
     SignedCertificateTimestampAndStatusList scts;
     TestNetLog test_net_log;
-    NetLogWithSource net_log =
-        NetLogWithSource::Make(&test_net_log, NetLogSourceType::CONNECT_JOB);
+    NetLogWithSource net_log = NetLogWithSource::Make(
+        &test_net_log, NetLogSourceType::SSL_CONNECT_JOB);

[mmenke, 2016/11/30 15:09:24]

Do these actually matter, or could you just use NetLotWithSource() inline,
below?

[davidben, 2016/11/30 17:37:49]

This one doesn't seem to, but the one below checks test_net_log.

 
     return verifier_->Verify(chain.get(), std::string(), std::string(), &scts,
                              net_log) == OK;
   }
 
   bool CheckPrecertificateVerification(scoped_refptr<X509Certificate> chain) {
     SignedCertificateTimestampAndStatusList scts;
     TestNetLog test_net_log;
-    NetLogWithSource net_log =
-        NetLogWithSource::Make(&test_net_log, NetLogSourceType::CONNECT_JOB);
+    NetLogWithSource net_log = NetLogWithSource::Make(
+        &test_net_log, NetLogSourceType::SSL_CONNECT_JOB);
     return (VerifySinglePrecertificateChain(chain, net_log, &scts) &&
             ct::CheckForSingleVerifiedSCTInResult(scts, kLogDescription) &&
             ct::CheckForSCTOrigin(
                 scts, ct::SignedCertificateTimestamp::SCT_EMBEDDED) &&
             CheckForEmbeddedSCTInNetLog(test_net_log));
   }
 
   // Histogram-related helper methods
   int GetValueFromHistogram(const std::string& histogram_name,
                             int sample_index) {
@@ skipping 144 matching lines @@
   Mock::VerifyAndClearExpectations(&observer);
 
   EXPECT_CALL(observer, OnSCTVerified(embedded_sct_chain_.get(), _)).Times(0);
   verifier_->SetObserver(nullptr);
   ASSERT_TRUE(VerifySinglePrecertificateChain(embedded_sct_chain_));
 }
 
 }  // namespace
 
 }  // namespace net