Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2537343008: Revert of Add command buffer support for EXT_sRGB_write_control (Closed)

Created:
4 years ago by enne (OOO)
Modified:
4 years ago
Reviewers:
Zhenyao Mo, ccameron
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add command buffer support for EXT_sRGB_write_control (patchset #9 id:160001 of https://codereview.chromium.org/2519603002/ ) Reason for revert: Breaks gl_tests on GPU FYI bots BUG=670487 Original issue's description: > Add command buffer support for EXT_sRGB_write_control > > This state is not set in the service side at glEnable/glDisable time. > Instead, it is set during framebuffer validation, to accommodate > driver bug workarounds on desktop. > > Move the logic for updating framebuffer SRGB in the decoder to > a separate function, GLES2DecoderImpl::UpdateFramebufferSRGB. > > BUG=655247 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/a48dcecc89523bf034b2138c308fc959380c8028 > Cr-Commit-Position: refs/heads/master@{#435631} TBR=zmo@chromium.org,ccameron@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=655247 Committed: https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832 Cr-Commit-Position: refs/heads/master@{#435773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -139 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/context_state.h View 1 chunk +1 line, -5 lines 0 comments Download
M gpu/command_buffer/service/context_state.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/context_state_autogen.h View 2 chunks +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/context_state_impl_autogen.h View 6 chunks +0 lines, -27 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 5 chunks +5 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 5 chunks +13 lines, -41 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_0_autogen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
enne (OOO)
Created Revert of Add command buffer support for EXT_sRGB_write_control
4 years ago (2016-12-01 23:50:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537343008/1
4 years ago (2016-12-01 23:51:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 23:52:30 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-01 23:55:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832
Cr-Commit-Position: refs/heads/master@{#435773}

Powered by Google App Engine
This is Rietveld 408576698