Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 2537343008: Revert of Add command buffer support for EXT_sRGB_write_control (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/feature_info_unittest.cc
diff --git a/gpu/command_buffer/service/feature_info_unittest.cc b/gpu/command_buffer/service/feature_info_unittest.cc
index 902a9531acd6e7a3155570dbe44524ce551d27e6..49b8d197da6be1566db60ec19e84ccef8f6d98c3 100644
--- a/gpu/command_buffer/service/feature_info_unittest.cc
+++ b/gpu/command_buffer/service/feature_info_unittest.cc
@@ -246,11 +246,8 @@
NOTREACHED();
break;
}
- // Note that because GL_EXT_sRGB is a substring of GL_EXT_sRGB_write_control,
- // which is not part of the ES3 core, we have to be careful to search for
- // "GL_EXT_sRGB ", and append a space to the end of the extension string.
if (expect_ext_srgb) {
- EXPECT_THAT(info_->extensions() + " ", HasSubstr("GL_EXT_sRGB "));
+ EXPECT_THAT(info_->extensions(), HasSubstr("GL_EXT_sRGB"));
EXPECT_TRUE(info_->validators()->texture_format.IsValid(GL_SRGB_EXT));
EXPECT_TRUE(info_->validators()->texture_format.IsValid(GL_SRGB_ALPHA_EXT));
EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid(
@@ -262,7 +259,7 @@
EXPECT_TRUE(info_->validators()->framebuffer_parameter.IsValid(
GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING_EXT));
} else {
- EXPECT_THAT(info_->extensions() + " ", Not(HasSubstr("GL_EXT_sRGB ")));
+ EXPECT_THAT(info_->extensions(), Not(HasSubstr("GL_EXT_sRGB")));
EXPECT_FALSE(info_->validators()->texture_format.IsValid(GL_SRGB_EXT));
EXPECT_FALSE(info_->validators()->texture_format.IsValid(
GL_SRGB_ALPHA_EXT));
@@ -596,7 +593,7 @@
SetupInitExpectations("GL_EXT_sRGB GL_OES_rgb8_rgba8");
if (GetContextType() == CONTEXT_TYPE_OPENGLES3) {
- EXPECT_THAT(info_->extensions() + " ", Not(HasSubstr("GL_EXT_sRGB ")));
+ EXPECT_THAT(info_->extensions(), Not(HasSubstr("GL_EXT_sRGB")));
EXPECT_FALSE(info_->validators()->texture_format.IsValid(GL_SRGB_EXT));
EXPECT_FALSE(
info_->validators()->texture_format.IsValid(GL_SRGB_ALPHA_EXT));
@@ -609,7 +606,7 @@
EXPECT_FALSE(info_->validators()->framebuffer_parameter.IsValid(
GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING_EXT));
} else {
- EXPECT_THAT(info_->extensions() + " ", HasSubstr("GL_EXT_sRGB "));
+ EXPECT_THAT(info_->extensions(), HasSubstr("GL_EXT_sRGB"));
EXPECT_TRUE(info_->validators()->texture_format.IsValid(GL_SRGB_EXT));
EXPECT_TRUE(info_->validators()->texture_format.IsValid(GL_SRGB_ALPHA_EXT));
EXPECT_TRUE(
@@ -925,7 +922,7 @@
TEST_P(FeatureInfoTest, Initialize_sRGBGLES3) {
SetupInitExpectationsWithGLVersion("", "", "OpenGL ES 3.0");
- EXPECT_THAT(info_->extensions() + " ", Not(HasSubstr("GL_EXT_sRGB ")));
+ EXPECT_THAT(info_->extensions(), Not(HasSubstr("GL_EXT_sRGB")));
EXPECT_FALSE(info_->validators()->texture_format.IsValid(
GL_SRGB_EXT));
EXPECT_FALSE(info_->validators()->texture_format.IsValid(
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698