Remove support for the keygen tag

Remove support for the keygen tag

This removes support for <keygen> by updating it
to be an HTMLUnknownElement. As a result, it's
no longer a form-associated element and no
longer has IDL-assigned properties.

The <keygen> tag is still left in the parser,
similar to <applet>, so that it maintains the
document parse behaviours (such as self-closing),
but is otherwise a neutered element.

Tests that were relying on <keygen> having its
own browser-created shadow root (for its custom
select element) have been updated to use
progress bars, while other tests (such as
<keygen>-related crash tests) have been
fully removed.

As Blink no longer treats this tag as special,
all the related IPC infrastructure is removed,
including preferences and enterprise flags,
and all localized strings, as they're all now
unreachable.

This concludes the "Intent to Remove" thread
for <keygen> at
https://groups.google.com/a/chromium.org/d/msg/blink-dev/z_qEpmzzKh8/BH-lkwdgBAAJ

BUG=568184
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5d916f6c6b47472770e03cb483f06a18ca79a0c2
Cr-Commit-Position: refs/heads/master@{#440245}

[Ryan Sleevi, 2016-11-29 01:48:55]

Description was changed from

==========
Burn keygen to the ground

BUG=
==========

to

==========
Burn keygen to the ground

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Ryan Sleevi, 2016-11-29 02:02:02]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 02:03:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 02:19:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 02:19:32]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Ryan Sleevi, 2016-11-30 03:02:04]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 03:03:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Sleevi, 2016-11-30 03:33:54]

Warning: Big CL, but not for review as is.


Dominic: It's a pretty far-reaching change, but I was hoping to poke you for
early advice if you can suggest possible reviewers, as well as possible tests I
should consider.

When going through the existing uses of <keygen> in Blink, I looked at
- Shadow DOM testing (to make sure it can't have a shadowRoot attached). I
replaced these with <progress>, which seems to share the same restriction
- Tests that <keygen> works. I deleted those :)
- Tests related to form inputs. I removed these from the test, since it's no
longer an HTMLFormElement
- Tests related to weird WebKit crash cases. I think these are silly and dumb,
but I left them alone because they don't fail :)

I still want to make sure I cover the right 'positive' test cases, if there were
any suggestions. Also, is there any advice/guidance on other deprecated
rendering tags that might inform the best way to break up this 'mega CL' ? My
thinking of sequencing was:
1) Nuke UI
2) Nuke from Blink
3) Nuke from Chrome

But I'm curious, given how large the Blink change is, if there's any ways to cut
that smaller, or if this is the norm.

[commit-bot: I haz the power, 2016-11-30 05:04:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 05:04:50]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Ryan Sleevi, 2016-12-01 01:06:02]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 01:07:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 01:13:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 01:13:43]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dominicc (has gone to gerrit), 2016-12-07 07:07:09]

dominicc@chromium.org changed reviewers:
+ dominicc@chromium.org

[dominicc (has gone to gerrit), 2016-12-07 07:07:11]

Looking forward immensely to this.

https://codereview.chromium.org/2536993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLTagNames.in (right):

https://codereview.chromium.org/2536993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLTagNames.in:74: keygen
interfaceName=HTMLElement
I didn't read through the whole thread, but Domenic's original post at
https://github.com/whatwg/html/issues/2079 indicates a change more like deleting
this line entirely.

As-is doing createElement('keygen') produces something with prototype
HTMLElement. Removing it entirely creates HTMLUnknownElement like any other
random element name.

[dominicc (has gone to gerrit), 2016-12-07 07:32:57]

Oops, just realized I missed the specific questions.

On Wed, Nov 30, 2016 at 12:33 PM, <rsleevi@chromium.org> wrote:

> Reviewers:
> CL: https://codereview.chromium.org/2536993002/
>
> Message:
> Warning: Big CL, but not for review as is.
>
>
> Dominic: It's a pretty far-reaching change, but I was hoping to poke you
> for
> early advice if you can suggest possible reviewers, as well as possible
> tests I
> should consider.
>

If you wanted to add a test, I suppose that createElement('keygen')
instanceof HTMLUnknownElement is about it.

You might be missing (or I missed) something like
global-interface-listing-expected.txt results. These appear in
virtual/stable etc. too. IIRC that test enumerates the window properties
and discovers HTMLKeygenElement constructor that way.


> When going through the existing uses of <keygen> in Blink, I looked at
> - Shadow DOM testing (to make sure it can't have a shadowRoot attached). I
> replaced these with <progress>, which seems to share the same restriction
> - Tests that <keygen> works. I deleted those :)
> - Tests related to form inputs. I removed these from the test, since it's
> no
> longer an HTMLFormElement
>

^^^ all of the above: perfect.


> - Tests related to weird WebKit crash cases. I think these are silly and
> dumb,
> but I left them alone because they don't fail :)
>

Feel free to delete them!


> I still want to make sure I cover the right 'positive' test cases, if
> there were
> any suggestions. Also, is there any advice/guidance on other deprecated
> rendering tags that might inform the best way to break up this 'mega CL' ?
> My
> thinking of sequencing was:
> 1) Nuke UI
> 2) Nuke from Blink
> 3) Nuke from Chrome
>
> But I'm curious, given how large the Blink change is, if there's any ways
> to cut
> that smaller, or if this is the norm.
>

I think the change is manageable. Just go for it.

You could do the blink change 'at once' by just cauterizing that client
didUseKeygen thing and maybe whatever is trafficking strings through
platform.

If you wanted to break up the blink part into teeny pieces:

- Delete the line from HTMLTagNames.in and nuke most layout tests.
Interesting behaviour disappears.
- Remove mentions from the UA stylesheets. Changes presentation.
- Remove the IDL file and nuke the remaining tests. Removes the
window.HTMLKeygenElement constructor.
- Delete HTMLKeygenElement.h, .cpp.
- Remove the unused didUseKeygen client interface.
- Remove the unused use counter and deprecation warning.

The label, localization stuff in platform should ride along with the
removal of whatever uses it, etc.


>
> Description:
> Burn keygen to the ground
>
> BUG=
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Affected files (+118, -3318 lines):
> M chrome/android/java/res/xml/single_website_preferences.xml
> M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/
> ContentSettingsResources.java
> D chrome/android/java/src/org/chromium/chrome/browser/preferences/website/
> KeygenInfo.java
> M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/
> SingleWebsitePreferences.java
> M chrome/android/java/src/org/chromium/chrome/browser/
> preferences/website/Website.java
> M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/
> WebsitePermissionsFetcher.java
> M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/
> WebsitePreferenceBridge.java
> M chrome/android/java/strings/android_chrome_strings.grd
> M chrome/android/java_sources.gni
> M chrome/android/javatests/src/org/chromium/chrome/browser/
> preferences/website/SiteSettingsPreferencesTest.java
> M chrome/app/generated_resources.grd
> M chrome/app/settings_strings.grdp
> D chrome/app/theme/default_100_percent/common/allowed_keygen.png
> D chrome/app/theme/default_100_percent/common/blocked_keygen.png
> D chrome/app/theme/default_200_percent/common/allowed_keygen.png
> D chrome/app/theme/default_200_percent/common/blocked_keygen.png
> M chrome/app/theme/theme_resources.grd
> M chrome/browser/android/preferences/website_preference_bridge.cc
> M chrome/browser/chrome_content_browser_client.h
> M chrome/browser/chrome_content_browser_client.cc
> M chrome/browser/content_settings/host_content_settings_map_unittest.cc
> M chrome/browser/content_settings/tab_specific_content_settings.h
> M chrome/browser/content_settings/tab_specific_content_settings.cc
> M chrome/browser/content_settings/tab_specific_content_
> settings_unittest.cc
> M chrome/browser/policy/configuration_policy_handler_list_factory.cc
> M chrome/browser/profiles/profile_io_data.h
> M chrome/browser/profiles/profile_io_data.cc
> M chrome/browser/resources/options/content_settings.html
> M chrome/browser/resources/options/content_settings_exceptions_area.html
> M chrome/browser/resources/settings/privacy_page/privacy_page.html
> M chrome/browser/resources/settings/route.js
> M chrome/browser/resources/settings/site_settings/constants.js
> M chrome/browser/resources/settings/site_settings/site_details.html
> M chrome/browser/resources/settings/site_settings/site_
> settings_behavior.js
> M chrome/browser/resources/settings/site_settings/site_
> settings_category.js
> M chrome/browser/resources/settings/site_settings_page/
> site_settings_page.html
> M chrome/browser/resources/settings/site_settings_page/
> site_settings_page.js
> M chrome/browser/ui/android/page_info/website_settings_popup_android.cc
> M chrome/browser/ui/crypto_module_password_dialog.h
> M chrome/browser/ui/views/crypto_module_password_dialog_view.cc
> M chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc
> M chrome/browser/ui/website_settings/website_settings.cc
> M chrome/browser/ui/website_settings/website_settings_ui.cc
> M chrome/browser/ui/webui/options/content_settings_handler.cc
> M chrome/browser/ui/webui/settings/md_settings_
> localized_strings_provider.cc
> M chrome/browser/ui/webui/settings/site_settings_handler.cc
> M chrome/browser/ui/webui/site_settings_helper.cc
> M chrome/browser/web_dev_style/css_checker.py
> M chrome/common/render_messages.h
> M chrome/renderer/content_settings_observer.h
> M chrome/renderer/content_settings_observer.cc
> M chrome/test/data/chromeos/enterprise/policies
> M chrome/test/data/policy/policy_test_cases.json
> M chrome/test/data/webui/settings/site_details_tests.js
> M chrome/test/data/webui/settings/site_list_tests.js
> M chrome/test/data/webui/settings/test_site_settings_
> prefs_browser_proxy.js
> M chromecast/BUILD.gn
> M components/content_settings/core/browser/content_settings_
> default_provider.cc
> M components/content_settings/core/browser/content_settings_
> policy_provider.cc
> M components/content_settings/core/browser/content_settings_registry.cc
> M components/content_settings/core/browser/host_content_settings_map.h
> M components/content_settings/core/browser/host_content_settings_map.cc
> M components/content_settings/core/common/content_settings.cc
> M components/content_settings/core/common/content_settings_types.h
> M components/content_settings/core/common/pref_names.h
> M components/content_settings/core/common/pref_names.cc
> M components/policy/resources/policy_templates.json
> M content/app/strings/content_strings.grd
> M content/browser/accessibility/dump_accessibility_tree_browsertest.cc
> M content/browser/loader/mime_sniffing_resource_handler.cc
> M content/browser/renderer_host/render_message_filter.h
> M content/browser/renderer_host/render_message_filter.cc
> M content/browser/resource_context_impl.cc
> M content/child/blink_platform_impl.h
> M content/child/blink_platform_impl.cc
> M content/common/render_process_messages.h
> M content/public/browser/content_browser_client.h
> M content/public/browser/content_browser_client.cc
> M content/public/browser/resource_context.h
> M content/renderer/renderer_blink_platform_impl.h
> M content/renderer/renderer_blink_platform_impl.cc
> D content/test/data/accessibility/html/keygen.html
> D content/test/data/accessibility/html/keygen-expected-win.txt
> M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc
> M net/BUILD.gn
> M net/android/network_library.h
> D net/base/keygen_handler.h
> D net/base/keygen_handler.cc
> D net/base/keygen_handler_mac.cc
> D net/base/keygen_handler_nss.cc
> D net/base/keygen_handler_openssl.cc
> D net/base/keygen_handler_unittest.cc
> D net/base/keygen_handler_win.cc
> D net/base/openssl_private_key_store.h
> D net/base/openssl_private_key_store_android.cc
> D net/base/openssl_private_key_store_memory.cc
> M net/net.gypi
> D net/third_party/mozilla_security_manager/nsKeygenHandler.h
> D net/third_party/mozilla_security_manager/nsKeygenHandler.cpp
> M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
> M third_party/WebKit/LayoutTests/SlowTests
> M third_party/WebKit/LayoutTests/TestExpectations
> M third_party/WebKit/LayoutTests/accessibility/
> content-changed-notification-causes-crash-expected.txt
> M third_party/WebKit/LayoutTests/accessibility/
> contenteditable-table-check-causes-crash-expected.txt
> M third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-
> crash-expected.txt
> M third_party/WebKit/LayoutTests/editing/execCommand/remove-format-
> elements-expected.txt
> M third_party/WebKit/LayoutTests/fast/block/child-not-removed-from-parent-
> lineboxes-crash-expected.txt
> M third_party/WebKit/LayoutTests/fast/block/float/
> float-not-removed-from-first-letter-expected.txt
> M third_party/WebKit/LayoutTests/fast/block/float/
> split-inline-sibling-of-float-crash-expected.txt
> M third_party/WebKit/LayoutTests/fast/css-grid-layout/stale-grid-layout-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/css/pseudo-
> required-optional-unapplied-expected.txt
> M third_party/WebKit/LayoutTests/fast/deprecated-
> flexbox/crash-button-keygen-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/HTMLFormElement/associated-
> elements-after-index-assertion-fail1-expected.txt
> D third_party/WebKit/LayoutTests/fast/dom/HTMLKeygenElement/keygen.html
> D third_party/WebKit/LayoutTests/fast/dom/HTMLKeygenElement/keygen-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/click-method-on-html-element-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/domstring-attribute-
> reflection.html
> M third_party/WebKit/LayoutTests/fast/dom/domstring-attribute-
> reflection-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/element-attribute-js-null.html
> M third_party/WebKit/LayoutTests/fast/dom/element-
> attribute-js-null-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/setCustomValidity-null-
> undefined.html
> M third_party/WebKit/LayoutTests/fast/dom/shadow/layout-tests-can-access-
> shadow.html
> M third_party/WebKit/LayoutTests/fast/dom/shadow/layout-tests-can-access-
> shadow-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/shadow/no-renderers-for-light-
> children.html
> M third_party/WebKit/LayoutTests/fast/dom/shadow/no-renderers-for-light-
> children-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/shadow/nodetype.html
> M third_party/WebKit/LayoutTests/fast/dom/shadow/nodetype-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable.html
> M third_party/WebKit/LayoutTests/fast/dom/shadow/
> shadow-disable-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/wrapper-classes.html
> M third_party/WebKit/LayoutTests/fast/dom/wrapper-classes-expected.txt
> M third_party/WebKit/LayoutTests/fast/dynamic/insertAdjacentHTML-allowed-
> parents-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/access-
> key-for-all-elements-expected.txt
> D third_party/WebKit/LayoutTests/fast/forms/autofocus-keygen.html
> M third_party/WebKit/LayoutTests/fast/forms/autofocus-keygen-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/checkValidity.html
> M third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements.
> html
> M third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-form-
> collection-radionode-list.html
> M third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-form-
> collection-radionode-list-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-associated-element.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> associated-element-crash3-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-
> associated-element-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-attribute.html
> M third_party/WebKit/LayoutTests/fast/forms/form-attribute-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-collection-elements.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> collection-elements-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-
> collection-elements-order.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> collection-elements-order-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-
> collection-radio-node-list.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> collection-radio-node-list-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-radio-img-node-list.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> radio-img-node-list-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-radio-node-list.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> radio-node-list-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/label-contains-other-
> interactive-content.html
> M third_party/WebKit/LayoutTests/fast/forms/label/label-contains-other-
> interactive-content-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labelable-elements-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labels-add-htmlFor-label-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/labels-add-parent-label-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/labels-change-htmlFor-
> attribute-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/labels-multiple-sibling-
> labels-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labels-parent-and-sibling-labels-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/labels-remove-htmlFor-
> attribute-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labels-remove-htmlFor-label-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labels-remove-parent-label-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labels-set-htmlFor-attribute-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/large-parts-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/reportValidity-valid.html
> M third_party/WebKit/LayoutTests/fast/forms/reportValidity-valid-expected.
> txt
> M third_party/WebKit/LayoutTests/fast/forms/resources/common.js
> M third_party/WebKit/LayoutTests/fast/forms/setCustomValidity-arguments.
> html
> M third_party/WebKit/LayoutTests/fast/forms/setCustomValidity-arguments-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/setCustomValidity-existence.
> html
> M third_party/WebKit/LayoutTests/fast/forms/setCustomValidity-existence-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/state-
> restore-skip-stateless.html
> M third_party/WebKit/LayoutTests/fast/forms/state-restore-skip-stateless-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/validationMessage.html
> M third_party/WebKit/LayoutTests/fast/forms/validationMessage-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/validity-property.html
> M third_party/WebKit/LayoutTests/fast/forms/validity-property-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/willvalidate.html
> M third_party/WebKit/LayoutTests/fast/forms/willvalidate-expected.txt
> D third_party/WebKit/LayoutTests/fast/html/clone-keygen.html
> M third_party/WebKit/LayoutTests/fast/html/clone-keygen-expected.txt
> D third_party/WebKit/LayoutTests/fast/html/keygen.html
> M third_party/WebKit/LayoutTests/fast/multicol/span/positioned-child-not-
> removed-crash-expected.txt
> M third_party/WebKit/LayoutTests/fast/replaced/
> keygen-as-table-column-group-crash-expected.txt
> M third_party/WebKit/LayoutTests/fast/ruby/float-
> object-doesnt-crash-expected.txt
> M third_party/WebKit/LayoutTests/fast/table/crash-
> splitColumn-2-expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests19-data-
> expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests19-write-
> expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests25-data-
> expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests25-write-
> expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests7-data-
> expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests7-write-
> expected.txt
> D third_party/WebKit/LayoutTests/http/tests/misc/submit-post-keygen.html
> D third_party/WebKit/LayoutTests/http/tests/misc/
> submit-post-keygen-expected.txt
> M third_party/WebKit/LayoutTests/imported/wpt/html/
> dom/reflection-forms-expected.txt
> M third_party/WebKit/LayoutTests/imported/wpt/html/
> semantics/forms/constraints/form-validation-willValidate-expected.txt
> [[ 38 additional files ]]
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dominicc (has gone to gerrit), 2016-12-07 07:32:58]

Oops, just realized I missed the specific questions.

On Wed, Nov 30, 2016 at 12:33 PM, <rsleevi@chromium.org> wrote:

> Reviewers:
> CL: https://codereview.chromium.org/2536993002/
>
> Message:
> Warning: Big CL, but not for review as is.
>
>
> Dominic: It's a pretty far-reaching change, but I was hoping to poke you
> for
> early advice if you can suggest possible reviewers, as well as possible
> tests I
> should consider.
>

If you wanted to add a test, I suppose that createElement('keygen')
instanceof HTMLUnknownElement is about it.

You might be missing (or I missed) something like
global-interface-listing-expected.txt results. These appear in
virtual/stable etc. too. IIRC that test enumerates the window properties
and discovers HTMLKeygenElement constructor that way.


> When going through the existing uses of <keygen> in Blink, I looked at
> - Shadow DOM testing (to make sure it can't have a shadowRoot attached). I
> replaced these with <progress>, which seems to share the same restriction
> - Tests that <keygen> works. I deleted those :)
> - Tests related to form inputs. I removed these from the test, since it's
> no
> longer an HTMLFormElement
>

^^^ all of the above: perfect.


> - Tests related to weird WebKit crash cases. I think these are silly and
> dumb,
> but I left them alone because they don't fail :)
>

Feel free to delete them!


> I still want to make sure I cover the right 'positive' test cases, if
> there were
> any suggestions. Also, is there any advice/guidance on other deprecated
> rendering tags that might inform the best way to break up this 'mega CL' ?
> My
> thinking of sequencing was:
> 1) Nuke UI
> 2) Nuke from Blink
> 3) Nuke from Chrome
>
> But I'm curious, given how large the Blink change is, if there's any ways
> to cut
> that smaller, or if this is the norm.
>

I think the change is manageable. Just go for it.

You could do the blink change 'at once' by just cauterizing that client
didUseKeygen thing and maybe whatever is trafficking strings through
platform.

If you wanted to break up the blink part into teeny pieces:

- Delete the line from HTMLTagNames.in and nuke most layout tests.
Interesting behaviour disappears.
- Remove mentions from the UA stylesheets. Changes presentation.
- Remove the IDL file and nuke the remaining tests. Removes the
window.HTMLKeygenElement constructor.
- Delete HTMLKeygenElement.h, .cpp.
- Remove the unused didUseKeygen client interface.
- Remove the unused use counter and deprecation warning.

The label, localization stuff in platform should ride along with the
removal of whatever uses it, etc.


>
> Description:
> Burn keygen to the ground
>
> BUG=
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Affected files (+118, -3318 lines):
> M chrome/android/java/res/xml/single_website_preferences.xml
> M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/
> ContentSettingsResources.java
> D chrome/android/java/src/org/chromium/chrome/browser/preferences/website/
> KeygenInfo.java
> M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/
> SingleWebsitePreferences.java
> M chrome/android/java/src/org/chromium/chrome/browser/
> preferences/website/Website.java
> M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/
> WebsitePermissionsFetcher.java
> M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/
> WebsitePreferenceBridge.java
> M chrome/android/java/strings/android_chrome_strings.grd
> M chrome/android/java_sources.gni
> M chrome/android/javatests/src/org/chromium/chrome/browser/
> preferences/website/SiteSettingsPreferencesTest.java
> M chrome/app/generated_resources.grd
> M chrome/app/settings_strings.grdp
> D chrome/app/theme/default_100_percent/common/allowed_keygen.png
> D chrome/app/theme/default_100_percent/common/blocked_keygen.png
> D chrome/app/theme/default_200_percent/common/allowed_keygen.png
> D chrome/app/theme/default_200_percent/common/blocked_keygen.png
> M chrome/app/theme/theme_resources.grd
> M chrome/browser/android/preferences/website_preference_bridge.cc
> M chrome/browser/chrome_content_browser_client.h
> M chrome/browser/chrome_content_browser_client.cc
> M chrome/browser/content_settings/host_content_settings_map_unittest.cc
> M chrome/browser/content_settings/tab_specific_content_settings.h
> M chrome/browser/content_settings/tab_specific_content_settings.cc
> M chrome/browser/content_settings/tab_specific_content_
> settings_unittest.cc
> M chrome/browser/policy/configuration_policy_handler_list_factory.cc
> M chrome/browser/profiles/profile_io_data.h
> M chrome/browser/profiles/profile_io_data.cc
> M chrome/browser/resources/options/content_settings.html
> M chrome/browser/resources/options/content_settings_exceptions_area.html
> M chrome/browser/resources/settings/privacy_page/privacy_page.html
> M chrome/browser/resources/settings/route.js
> M chrome/browser/resources/settings/site_settings/constants.js
> M chrome/browser/resources/settings/site_settings/site_details.html
> M chrome/browser/resources/settings/site_settings/site_
> settings_behavior.js
> M chrome/browser/resources/settings/site_settings/site_
> settings_category.js
> M chrome/browser/resources/settings/site_settings_page/
> site_settings_page.html
> M chrome/browser/resources/settings/site_settings_page/
> site_settings_page.js
> M chrome/browser/ui/android/page_info/website_settings_popup_android.cc
> M chrome/browser/ui/crypto_module_password_dialog.h
> M chrome/browser/ui/views/crypto_module_password_dialog_view.cc
> M chrome/browser/ui/views/crypto_module_password_dialog_view_unittest.cc
> M chrome/browser/ui/website_settings/website_settings.cc
> M chrome/browser/ui/website_settings/website_settings_ui.cc
> M chrome/browser/ui/webui/options/content_settings_handler.cc
> M chrome/browser/ui/webui/settings/md_settings_
> localized_strings_provider.cc
> M chrome/browser/ui/webui/settings/site_settings_handler.cc
> M chrome/browser/ui/webui/site_settings_helper.cc
> M chrome/browser/web_dev_style/css_checker.py
> M chrome/common/render_messages.h
> M chrome/renderer/content_settings_observer.h
> M chrome/renderer/content_settings_observer.cc
> M chrome/test/data/chromeos/enterprise/policies
> M chrome/test/data/policy/policy_test_cases.json
> M chrome/test/data/webui/settings/site_details_tests.js
> M chrome/test/data/webui/settings/site_list_tests.js
> M chrome/test/data/webui/settings/test_site_settings_
> prefs_browser_proxy.js
> M chromecast/BUILD.gn
> M components/content_settings/core/browser/content_settings_
> default_provider.cc
> M components/content_settings/core/browser/content_settings_
> policy_provider.cc
> M components/content_settings/core/browser/content_settings_registry.cc
> M components/content_settings/core/browser/host_content_settings_map.h
> M components/content_settings/core/browser/host_content_settings_map.cc
> M components/content_settings/core/common/content_settings.cc
> M components/content_settings/core/common/content_settings_types.h
> M components/content_settings/core/common/pref_names.h
> M components/content_settings/core/common/pref_names.cc
> M components/policy/resources/policy_templates.json
> M content/app/strings/content_strings.grd
> M content/browser/accessibility/dump_accessibility_tree_browsertest.cc
> M content/browser/loader/mime_sniffing_resource_handler.cc
> M content/browser/renderer_host/render_message_filter.h
> M content/browser/renderer_host/render_message_filter.cc
> M content/browser/resource_context_impl.cc
> M content/child/blink_platform_impl.h
> M content/child/blink_platform_impl.cc
> M content/common/render_process_messages.h
> M content/public/browser/content_browser_client.h
> M content/public/browser/content_browser_client.cc
> M content/public/browser/resource_context.h
> M content/renderer/renderer_blink_platform_impl.h
> M content/renderer/renderer_blink_platform_impl.cc
> D content/test/data/accessibility/html/keygen.html
> D content/test/data/accessibility/html/keygen-expected-win.txt
> M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc
> M net/BUILD.gn
> M net/android/network_library.h
> D net/base/keygen_handler.h
> D net/base/keygen_handler.cc
> D net/base/keygen_handler_mac.cc
> D net/base/keygen_handler_nss.cc
> D net/base/keygen_handler_openssl.cc
> D net/base/keygen_handler_unittest.cc
> D net/base/keygen_handler_win.cc
> D net/base/openssl_private_key_store.h
> D net/base/openssl_private_key_store_android.cc
> D net/base/openssl_private_key_store_memory.cc
> M net/net.gypi
> D net/third_party/mozilla_security_manager/nsKeygenHandler.h
> D net/third_party/mozilla_security_manager/nsKeygenHandler.cpp
> M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
> M third_party/WebKit/LayoutTests/SlowTests
> M third_party/WebKit/LayoutTests/TestExpectations
> M third_party/WebKit/LayoutTests/accessibility/
> content-changed-notification-causes-crash-expected.txt
> M third_party/WebKit/LayoutTests/accessibility/
> contenteditable-table-check-causes-crash-expected.txt
> M third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-
> crash-expected.txt
> M third_party/WebKit/LayoutTests/editing/execCommand/remove-format-
> elements-expected.txt
> M third_party/WebKit/LayoutTests/fast/block/child-not-removed-from-parent-
> lineboxes-crash-expected.txt
> M third_party/WebKit/LayoutTests/fast/block/float/
> float-not-removed-from-first-letter-expected.txt
> M third_party/WebKit/LayoutTests/fast/block/float/
> split-inline-sibling-of-float-crash-expected.txt
> M third_party/WebKit/LayoutTests/fast/css-grid-layout/stale-grid-layout-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/css/pseudo-
> required-optional-unapplied-expected.txt
> M third_party/WebKit/LayoutTests/fast/deprecated-
> flexbox/crash-button-keygen-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/HTMLFormElement/associated-
> elements-after-index-assertion-fail1-expected.txt
> D third_party/WebKit/LayoutTests/fast/dom/HTMLKeygenElement/keygen.html
> D third_party/WebKit/LayoutTests/fast/dom/HTMLKeygenElement/keygen-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/click-method-on-html-element-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/domstring-attribute-
> reflection.html
> M third_party/WebKit/LayoutTests/fast/dom/domstring-attribute-
> reflection-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/element-attribute-js-null.html
> M third_party/WebKit/LayoutTests/fast/dom/element-
> attribute-js-null-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/setCustomValidity-null-
> undefined.html
> M third_party/WebKit/LayoutTests/fast/dom/shadow/layout-tests-can-access-
> shadow.html
> M third_party/WebKit/LayoutTests/fast/dom/shadow/layout-tests-can-access-
> shadow-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/shadow/no-renderers-for-light-
> children.html
> M third_party/WebKit/LayoutTests/fast/dom/shadow/no-renderers-for-light-
> children-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/shadow/nodetype.html
> M third_party/WebKit/LayoutTests/fast/dom/shadow/nodetype-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable.html
> M third_party/WebKit/LayoutTests/fast/dom/shadow/
> shadow-disable-expected.txt
> M third_party/WebKit/LayoutTests/fast/dom/wrapper-classes.html
> M third_party/WebKit/LayoutTests/fast/dom/wrapper-classes-expected.txt
> M third_party/WebKit/LayoutTests/fast/dynamic/insertAdjacentHTML-allowed-
> parents-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/access-
> key-for-all-elements-expected.txt
> D third_party/WebKit/LayoutTests/fast/forms/autofocus-keygen.html
> M third_party/WebKit/LayoutTests/fast/forms/autofocus-keygen-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/checkValidity.html
> M third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements.
> html
> M third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-form-
> collection-radionode-list.html
> M third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-form-
> collection-radionode-list-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-associated-element.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> associated-element-crash3-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-
> associated-element-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-attribute.html
> M third_party/WebKit/LayoutTests/fast/forms/form-attribute-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-collection-elements.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> collection-elements-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-
> collection-elements-order.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> collection-elements-order-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-
> collection-radio-node-list.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> collection-radio-node-list-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-radio-img-node-list.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> radio-img-node-list-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/form-radio-node-list.html
> M third_party/WebKit/LayoutTests/fast/forms/form-
> radio-node-list-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/label-contains-other-
> interactive-content.html
> M third_party/WebKit/LayoutTests/fast/forms/label/label-contains-other-
> interactive-content-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labelable-elements-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labels-add-htmlFor-label-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/labels-add-parent-label-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/labels-change-htmlFor-
> attribute-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/labels-multiple-sibling-
> labels-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labels-parent-and-sibling-labels-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/labels-remove-htmlFor-
> attribute-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labels-remove-htmlFor-label-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labels-remove-parent-label-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/label/
> labels-set-htmlFor-attribute-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/large-parts-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/reportValidity-valid.html
> M third_party/WebKit/LayoutTests/fast/forms/reportValidity-valid-expected.
> txt
> M third_party/WebKit/LayoutTests/fast/forms/resources/common.js
> M third_party/WebKit/LayoutTests/fast/forms/setCustomValidity-arguments.
> html
> M third_party/WebKit/LayoutTests/fast/forms/setCustomValidity-arguments-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/setCustomValidity-existence.
> html
> M third_party/WebKit/LayoutTests/fast/forms/setCustomValidity-existence-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/state-
> restore-skip-stateless.html
> M third_party/WebKit/LayoutTests/fast/forms/state-restore-skip-stateless-
> expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/validationMessage.html
> M third_party/WebKit/LayoutTests/fast/forms/validationMessage-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/validity-property.html
> M third_party/WebKit/LayoutTests/fast/forms/validity-property-expected.txt
> M third_party/WebKit/LayoutTests/fast/forms/willvalidate.html
> M third_party/WebKit/LayoutTests/fast/forms/willvalidate-expected.txt
> D third_party/WebKit/LayoutTests/fast/html/clone-keygen.html
> M third_party/WebKit/LayoutTests/fast/html/clone-keygen-expected.txt
> D third_party/WebKit/LayoutTests/fast/html/keygen.html
> M third_party/WebKit/LayoutTests/fast/multicol/span/positioned-child-not-
> removed-crash-expected.txt
> M third_party/WebKit/LayoutTests/fast/replaced/
> keygen-as-table-column-group-crash-expected.txt
> M third_party/WebKit/LayoutTests/fast/ruby/float-
> object-doesnt-crash-expected.txt
> M third_party/WebKit/LayoutTests/fast/table/crash-
> splitColumn-2-expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests19-data-
> expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests19-write-
> expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests25-data-
> expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests25-write-
> expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests7-data-
> expected.txt
> M third_party/WebKit/LayoutTests/html5lib/generated/run-tests7-write-
> expected.txt
> D third_party/WebKit/LayoutTests/http/tests/misc/submit-post-keygen.html
> D third_party/WebKit/LayoutTests/http/tests/misc/
> submit-post-keygen-expected.txt
> M third_party/WebKit/LayoutTests/imported/wpt/html/
> dom/reflection-forms-expected.txt
> M third_party/WebKit/LayoutTests/imported/wpt/html/
> semantics/forms/constraints/form-validation-willValidate-expected.txt
> [[ 38 additional files ]]
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ryan Sleevi, 2016-12-10 01:37:33]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 01:38:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 01:45:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 01:45:28]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ryan Sleevi, 2016-12-10 02:23:20]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 02:23:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 02:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 02:48:04]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ryan Sleevi, 2016-12-12 21:34:26]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 21:36:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Sleevi, 2016-12-12 22:26:52]

Description was changed from

==========
Burn keygen to the ground

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove support for the keygen tag

This removes support for <keygen> by updating it to be an HTMLUnknownElement. As
a result, it's no longer a form-associated element and no longer has
IDL-assigned properties.

The <keygen> tag is still left in the parser, similar to <applet>, so that it
maintains the document parse behaviours (such as self-closing), but is otherwise
a neutered element.

Tests that were relying on <keygen> having its own browser-created shadow root
(for its custom select element) have been updated to use progress bars, while
other tests (such as <keygen>-related crash tests) have been fully removed.

As Blink no longer treats this tag as special, all the related IPC
infrastructure is removed, including preferences and enterprise flags, and all
localized strings, as they're all now unreachable.

BUG=667876
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Ryan Sleevi, 2016-12-12 22:28:11]

Description was changed from

==========
Remove support for the keygen tag

This removes support for <keygen> by updating it to be an HTMLUnknownElement. As
a result, it's no longer a form-associated element and no longer has
IDL-assigned properties.

The <keygen> tag is still left in the parser, similar to <applet>, so that it
maintains the document parse behaviours (such as self-closing), but is otherwise
a neutered element.

Tests that were relying on <keygen> having its own browser-created shadow root
(for its custom select element) have been updated to use progress bars, while
other tests (such as <keygen>-related crash tests) have been fully removed.

As Blink no longer treats this tag as special, all the related IPC
infrastructure is removed, including preferences and enterprise flags, and all
localized strings, as they're all now unreachable.

BUG=667876
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove support for the keygen tag

This removes support for <keygen> by updating it
to be an HTMLUnknownElement. As a result, it's
no longer a form-associated element and no
longer has IDL-assigned properties.

The <keygen> tag is still left in the parser,
similar to <applet>, so that it maintains the
document parse behaviours (such as self-closing),
but is otherwise a neutered element.

Tests that were relying on <keygen> having its
own browser-created shadow root (for its custom
select element) have been updated to use
progress bars, while other tests (such as
<keygen>-related crash tests) have been
fully removed.

As Blink no longer treats this tag as special,
all the related IPC infrastructure is removed,
including preferences and enterprise flags,
and all localized strings, as they're all now
unreachable.

BUG=667876
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Ryan Sleevi, 2016-12-12 22:28:12]

rsleevi@chromium.org changed reviewers:
+ jochen@chromium.org

[Ryan Sleevi, 2016-12-12 22:29:07]

rsleevi@chromium.org changed reviewers:
+ svaldez@chromium.org

[Ryan Sleevi, 2016-12-12 22:34:11]

svaldez: //net OWNERS and for your keygen familiarity
dominic, jochen: I'm not sure how to best split between OWNERS here. I've tried
to capture the nuance in the CL description - this leaves the parser logic in
place (handling things like self-closing tags) for the near-term, rather than
fully removing all parser logic, in order to minimize any compat issues. I've
instead focused on neutering the object, as per the blink-dev thread.

My own order of approach was:
- Update the HTMLTags
- Remove the HTMLKeygenElement
- Go through all test failures and work through
  - Shadow DOM (replace with progress)
  - Form elements (remove keygen from element test)
  - IDL tests (update expectations)
  * Note: There's some upstream WPT test failures that I added an -expected.txt
file for, simply because I'm not sure how much we want to gate on upstream - but
they're expected/benign failures

On the Chrome/content side,
- Remove the IPC endpoints
- Remove the associated logic handlers
- Remove the localized strings & histograms
- Remove the enterprise policies (which is causing presubmit issues, because the
presubmit script doesn't like that I'm updating the version number while
removing the test)

This is, as far as I can tell, a complete neutering of the object.

One thing I'm unclear of is whether we should proactively nuke any associated
content settings - I don't see any precedent for that, but can totally buy the
argument that we should keep some logic around for destroying those.

[commit-bot: I haz the power, 2016-12-12 23:31:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 23:31:08]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[svaldez, 2016-12-13 15:15:49]

Few more changes that might be needed? Otherwise LGTM for keygen changes, though
I think you'll need someone else for actual //net OWNERS stamp.

Update NO_PRIVATE_KEY_FOR_CERT comment.
 net/base/net_error_list.h

Removable:

third_party/WebKit/LayoutTests/fast/replaced/keygen-as-table-column-group-crash.html
 third_party/WebKit/LayoutTests/http/tests/misc/resources/check-keygen-post.php
Remove the keygen comments:

third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/resetting-a-form/reset-form.html

[jochen (gone - plz use gerrit), 2016-12-14 11:35:22]

can you please link from the CL description to the intent to remove?

the link from the bugreport is only about deprecation, no?

[Ryan Sleevi, 2016-12-15 02:48:22]

On 2016/12/14 11:35:22, jochen wrote:
> can you please link from the CL description to the intent to remove?
> 
> the link from the bugreport is only about deprecation, no?

Right, I needed a bug for the I2R, but I didn't update the bug with the I2R
conclusion - now done in the bug ( and
https://groups.google.com/a/chromium.org/d/msg/blink-dev/z_qEpmzzKh8/BH-lkwdg...
for reference). Do you also want it in the commit description?

[dominicc (has gone to gerrit), 2016-12-15 06:31:48]

core/html, layout tests LGTM.

There are some tests which could omit mentioning keygen now, but it kind of
makes sense to leave it in their if it doesn't complicate the test, so what
you've prepared LGTM.

https://codereview.chromium.org/2536993002/diff/200001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (left):

https://codereview.chromium.org/2536993002/diff/200001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:722: crbug.com/520189 [ Mac ]
http/tests/misc/submit-post-keygen.html [ Pass Timeout ]
Looks like some bots are complaining about keygen appearing here still
somewhere:

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...

https://codereview.chromium.org/2536993002/diff/200001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-crash.html
(left):

https://codereview.chromium.org/2536993002/diff/200001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-crash.html:1:
<!doctype html>
Who owns LayoutTests/accessibility? Perhaps this test could be salvaged by
replacing keygen with something else.

[jochen (gone - plz use gerrit), 2016-12-15 14:17:41]

yes, please put the link into the CL description!

lgtm

[Ryan Sleevi, 2016-12-16 01:45:54]

rsleevi@chromium.org changed reviewers:
+ dmazzoni@chromium.org, mattm@chromium.org

[Ryan Sleevi, 2016-12-16 01:45:57]

dmazzoni: See below re: Accessibility layout tests

Adding mattm for //net stampy

https://codereview.chromium.org/2536993002/diff/200001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-crash.html
(left):

https://codereview.chromium.org/2536993002/diff/200001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-crash.html:1:
<!doctype html>
On 2016/12/15 06:31:47, dominicc (away 12.23-1.10) wrote:
> Who owns LayoutTests/accessibility? Perhaps this test could be salvaged by
> replacing keygen with something else.

This is the specific file I was thinking about when I mentioned not being sure
which files related to obscure WebKit crash tests are relevant.

As far as tests go, this seems like a bad test to begin with (and the upstream
bug is still restricted), but TL;DR is that it's roughly similar to the
shadow-dom tests (where an element - keygen - results in other objects -
previously, a <select> - being created as part of the tree), so it didn't seem
worth keeping.

[Ryan Sleevi, 2016-12-16 01:46:55]

Description was changed from

==========
Remove support for the keygen tag

This removes support for <keygen> by updating it
to be an HTMLUnknownElement. As a result, it's
no longer a form-associated element and no
longer has IDL-assigned properties.

The <keygen> tag is still left in the parser,
similar to <applet>, so that it maintains the
document parse behaviours (such as self-closing),
but is otherwise a neutered element.

Tests that were relying on <keygen> having its
own browser-created shadow root (for its custom
select element) have been updated to use
progress bars, while other tests (such as
<keygen>-related crash tests) have been
fully removed.

As Blink no longer treats this tag as special,
all the related IPC infrastructure is removed,
including preferences and enterprise flags,
and all localized strings, as they're all now
unreachable.

BUG=667876
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove support for the keygen tag

This removes support for <keygen> by updating it
to be an HTMLUnknownElement. As a result, it's
no longer a form-associated element and no
longer has IDL-assigned properties.

The <keygen> tag is still left in the parser,
similar to <applet>, so that it maintains the
document parse behaviours (such as self-closing),
but is otherwise a neutered element.

Tests that were relying on <keygen> having its
own browser-created shadow root (for its custom
select element) have been updated to use
progress bars, while other tests (such as
<keygen>-related crash tests) have been
fully removed.

As Blink no longer treats this tag as special,
all the related IPC infrastructure is removed,
including preferences and enterprise flags,
and all localized strings, as they're all now
unreachable.

This concludes the "Intent to Remove" thread
for <keygen> at
https://groups.google.com/a/chromium.org/d/msg/blink-dev/z_qEpmzzKh8/BH-lkwdg...

BUG=568184
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Ryan Sleevi, 2016-12-16 01:55:21]

rsleevi@chromium.org changed reviewers:
+ bauerb@chromium.org, dbeam@chromium.org, droger@chromium.org

[Ryan Sleevi, 2016-12-16 01:55:22]

bauerb: Could you review the Content Settings related changes (both for Chrome &
Android)
dbeam: Can you vet the ui side of the site_settings
droger: Can you stamp the ios/ change
alokp: Can you stamp the chromecast/ change
mkwst: Can you stamp the IPC message removals (plus whatever bits of
third_party/WebKit aren't already covered by jochen, which git cl owners is
telling me relates to the public headers)

[Ryan Sleevi, 2016-12-16 01:57:39]

rsleevi@chromium.org changed reviewers:
+ isherman@chromium.org, pastarmovj@chromium.org

[Ryan Sleevi, 2016-12-16 01:57:41]

isherman: Can you vet the metrics changes
pastarmovj: Can you vet the enterprise templates (since bartfab is OOO, and
atwilson & tnagel are both set as slow)

[Ilya Sherman, 2016-12-16 09:01:12]

//tools/metrics lgtm

[pastarmovj, 2016-12-16 09:12:10]

policy_templates lgtm.

[droger, 2016-12-16 09:20:08]

ios lgtm

[Bernhard Bauer, 2016-12-16 16:38:01]

content settings LGTM.

[dmazzoni, 2016-12-16 17:17:18]

lgtm for accessibility

[dmazzoni, 2016-12-16 17:23:17]

https://codereview.chromium.org/2536993002/diff/240001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-crash.html
(left):

https://codereview.chromium.org/2536993002/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-crash.html:11:
<keygen></keygen>
FWIW, I spent about 15 minutes trying to get this test to crash without your
patch (reverting the fix from when this test was added), but I couldn't, so I
guess the test isn't needed anymore.

[halliwell, 2016-12-16 18:42:59]

On 2016/12/16 17:23:17, dmazzoni wrote:
>
https://codereview.chromium.org/2536993002/diff/240001/third_party/WebKit/Lay...
> File
>
third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-crash.html
> (left):
> 
>
https://codereview.chromium.org/2536993002/diff/240001/third_party/WebKit/Lay...
>
third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-crash.html:11:
> <keygen></keygen>
> FWIW, I spent about 15 minutes trying to get this test to crash without your
> patch (reverting the fix from when this test was added), but I couldn't, so I
> guess the test isn't needed anymore.

chromecast/ lgtm

[Ryan Sleevi, 2016-12-16 18:57:56]

rsleevi@chromium.org changed reviewers:
+ dcheng@chromium.org

[Ryan Sleevi, 2016-12-16 18:57:58]

Missed that I didn't actually add Mike for the IPC messages, but since he's
marked slow, adding dcheng to stamp the IPC removals :)

[mattm, 2016-12-16 20:59:48]

net lgtm

[dcheng, 2016-12-16 23:49:59]

IPC RS LGTM

[Dan Beam, 2016-12-17 01:30:58]

lgtm

[Ryan Sleevi, 2016-12-17 13:21:30]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-17 13:21:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 13:26:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 13:26:12]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Ryan Sleevi, 2016-12-20 01:52:50]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 01:53:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 03:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 03:54:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Sleevi, 2016-12-20 23:18:10]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 23:18:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 23:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 23:49:27]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ryan Sleevi, 2016-12-20 23:59:55]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 00:00:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Sleevi, 2016-12-21 00:02:29]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 00:03:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 01:46:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 01:46:32]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ryan Sleevi, 2016-12-21 07:39:11]

The CQ bit was checked by rsleevi@chromium.org

[Ryan Sleevi, 2016-12-21 07:39:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
svaldez@chromium.org, jochen@chromium.org, dominicc@chromium.org,
bauerb@chromium.org, droger@chromium.org, isherman@chromium.org,
dcheng@chromium.org, dmazzoni@chromium.org, halliwell@chromium.org,
mattm@chromium.org, pastarmovj@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2536993002/#ps340001
(title: "Rebased")

[commit-bot: I haz the power, 2016-12-21 07:39:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 07:55:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 07:55:59]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sgurun-gerrit only, 2016-12-21 18:49:05]

sgurun@chromium.org changed reviewers:
+ sgurun@chromium.org

[sgurun-gerrit only, 2016-12-21 18:49:08]

aw lgtm

[Ryan Sleevi, 2016-12-21 18:50:27]

The CQ bit was checked by rsleevi@chromium.org

[Ryan Sleevi, 2016-12-21 18:50:29]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
droger@chromium.org, svaldez@chromium.org, jochen@chromium.org,
dominicc@chromium.org, isherman@chromium.org, dcheng@chromium.org,
dmazzoni@chromium.org, halliwell@chromium.org, mattm@chromium.org,
pastarmovj@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2536993002/#ps310250
(title: "Rebased")

[commit-bot: I haz the power, 2016-12-21 18:50:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 22:39:47]

CQ is committing da patch.

Bot data: {"patchset_id": 310250, "attempt_start_ts": 1482346227772470,
"parent_rev": "2ea2a6636446d643eee60ee89b670b82ca8fca50", "commit_rev":
"f98bcfcb0739b704583413b806ba404ddc9dc2c1"}

[commit-bot: I haz the power, 2016-12-21 22:40:28]

Description was changed from

==========
Remove support for the keygen tag

This removes support for <keygen> by updating it
to be an HTMLUnknownElement. As a result, it's
no longer a form-associated element and no
longer has IDL-assigned properties.

The <keygen> tag is still left in the parser,
similar to <applet>, so that it maintains the
document parse behaviours (such as self-closing),
but is otherwise a neutered element.

Tests that were relying on <keygen> having its
own browser-created shadow root (for its custom
select element) have been updated to use
progress bars, while other tests (such as
<keygen>-related crash tests) have been
fully removed.

As Blink no longer treats this tag as special,
all the related IPC infrastructure is removed,
including preferences and enterprise flags,
and all localized strings, as they're all now
unreachable.

This concludes the "Intent to Remove" thread
for <keygen> at
https://groups.google.com/a/chromium.org/d/msg/blink-dev/z_qEpmzzKh8/BH-lkwdg...

BUG=568184
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove support for the keygen tag

This removes support for <keygen> by updating it
to be an HTMLUnknownElement. As a result, it's
no longer a form-associated element and no
longer has IDL-assigned properties.

The <keygen> tag is still left in the parser,
similar to <applet>, so that it maintains the
document parse behaviours (such as self-closing),
but is otherwise a neutered element.

Tests that were relying on <keygen> having its
own browser-created shadow root (for its custom
select element) have been updated to use
progress bars, while other tests (such as
<keygen>-related crash tests) have been
fully removed.

As Blink no longer treats this tag as special,
all the related IPC infrastructure is removed,
including preferences and enterprise flags,
and all localized strings, as they're all now
unreachable.

This concludes the "Intent to Remove" thread
for <keygen> at
https://groups.google.com/a/chromium.org/d/msg/blink-dev/z_qEpmzzKh8/BH-lkwdg...

BUG=568184
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2536993002
==========

[commit-bot: I haz the power, 2016-12-21 22:40:32]

Committed patchset #19 (id:310250)

[commit-bot: I haz the power, 2016-12-21 22:42:55]

Description was changed from

==========
Remove support for the keygen tag

This removes support for <keygen> by updating it
to be an HTMLUnknownElement. As a result, it's
no longer a form-associated element and no
longer has IDL-assigned properties.

The <keygen> tag is still left in the parser,
similar to <applet>, so that it maintains the
document parse behaviours (such as self-closing),
but is otherwise a neutered element.

Tests that were relying on <keygen> having its
own browser-created shadow root (for its custom
select element) have been updated to use
progress bars, while other tests (such as
<keygen>-related crash tests) have been
fully removed.

As Blink no longer treats this tag as special,
all the related IPC infrastructure is removed,
including preferences and enterprise flags,
and all localized strings, as they're all now
unreachable.

This concludes the "Intent to Remove" thread
for <keygen> at
https://groups.google.com/a/chromium.org/d/msg/blink-dev/z_qEpmzzKh8/BH-lkwdg...

BUG=568184
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2536993002
==========

to

==========
Remove support for the keygen tag

This removes support for <keygen> by updating it
to be an HTMLUnknownElement. As a result, it's
no longer a form-associated element and no
longer has IDL-assigned properties.

The <keygen> tag is still left in the parser,
similar to <applet>, so that it maintains the
document parse behaviours (such as self-closing),
but is otherwise a neutered element.

Tests that were relying on <keygen> having its
own browser-created shadow root (for its custom
select element) have been updated to use
progress bars, while other tests (such as
<keygen>-related crash tests) have been
fully removed.

As Blink no longer treats this tag as special,
all the related IPC infrastructure is removed,
including preferences and enterprise flags,
and all localized strings, as they're all now
unreachable.

This concludes the "Intent to Remove" thread
for <keygen> at
https://groups.google.com/a/chromium.org/d/msg/blink-dev/z_qEpmzzKh8/BH-lkwdg...

BUG=568184
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5d916f6c6b47472770e03cb483f06a18ca79a0c2
Cr-Commit-Position: refs/heads/master@{#440245}
==========

[commit-bot: I haz the power, 2016-12-21 22:42:59]

Patchset 19 (id:??) landed as
https://crrev.com/5d916f6c6b47472770e03cb483f06a18ca79a0c2
Cr-Commit-Position: refs/heads/master@{#440245}