third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-crash.html - Issue 2536993002: Remove support for the keygen tag

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-crash.html

Issue 2536993002: Remove support for the keygen tag (Closed)

Patch Set: Rebased Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/LayoutTests/accessibility/contenteditable-table-check-causes-crash-expected.txt ('k') | third_party/WebKit/LayoutTests/accessibility/duplicate-axlayoutobject-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!doctype html>
dominicc (has gone to gerrit) 2016/12/15 06:31:47 Who owns LayoutTests/accessibility? Perhaps this t Who owns LayoutTests/accessibility? Perhaps this test could be salvaged by replacing keygen with something else. Ryan Sleevi 2016/12/16 01:45:57 This is the specific file I was thinking about whe Show quoted text On 2016/12/15 06:31:47, dominicc (away 12.23-1.10) wrote: > Who owns LayoutTests/accessibility? Perhaps this test could be salvaged by > replacing keygen with something else. This is the specific file I was thinking about when I mentioned not being sure which files related to obscure WebKit crash tests are relevant. As far as tests go, this seems like a bad test to begin with (and the upstream bug is still restricted), but TL;DR is that it's roughly similar to the shadow-dom tests (where an element - keygen - results in other objects - previously, a <select> - being created as part of the tree), so it didn't seem worth keeping.
2 <html>

3 <head>

4 <script src="../resources/js-test.js"></script>

5 </head>

6 <body>

7

8 <label>

9 <summary>

10 <ul style="display: table-header-group">

11 <keygen></keygen>

12 </ul>

13 </summary>

14 </label>

15

16 <p id="description"></p>

17

18 <script>

19 description("Ensures that it's not possible to have two AXLayoutObjects that point to the same renderer, if the initialization of an AXLayoutObject results in another object with the same renderer being created before AXObjectCache has added that mapping to its hash.");

20 if (window.accessibilityController)

21 accessibilityController.accessibleElementById("dummy");

22 </script>

23

24

25 </body>

26 </html>

OLD	NEW