Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2536903002: [Extensions WebUI] Clean up ExtensionSettingsUIBrowserTest (Closed)

Created:
4 years ago by Devlin
Modified:
4 years ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions WebUI] Clean up ExtensionSettingsUIBrowserTest Clean up ExtensionSettingsUIBrowserTest. Most notably, use the utility class ChromeTestExtensionLoader() rather than re-implementing the load extension functionality. Also remove some unneeded members, includes, complexity, etc. BUG=667587 Committed: https://crrev.com/55f2b623d3cb915156f24f7efdd09e3b64bd43e4 Cr-Commit-Position: refs/heads/master@{#436411}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -158 lines) Patch
M chrome/browser/extensions/chrome_test_extension_loader.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.h View 1 2 3 3 chunks +7 lines, -23 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc View 1 2 3 3 chunks +17 lines, -133 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
Devlin
Dan, can you take a look when you get a chance?
4 years ago (2016-11-28 23:50:56 UTC) #5
Dan Beam
i have very little idea what this code is doing but i see a bunch ...
4 years ago (2016-12-01 07:03:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536903002/20001
4 years ago (2016-12-01 15:49:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/315687) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-01 15:52:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536903002/60001
4 years ago (2016-12-05 21:19:35 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-05 21:26:28 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-05 21:29:55 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/55f2b623d3cb915156f24f7efdd09e3b64bd43e4
Cr-Commit-Position: refs/heads/master@{#436411}

Powered by Google App Engine
This is Rietveld 408576698