[Extensions WebUI] Clean up ExtensionSettingsUIBrowserTest

chrome/browser/extensions/chrome_test_extension_loader.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/chrome_test_extension_loader.h"
 
 #include <memory>
 
 #include "base/files/file_util.h"
 #include "base/run_loop.h"
@@ skipping 39 matching lines @@
 
   if (should_fail_ && extension)
     ADD_FAILURE() << "Expected extension installation failure, but succeeded";
   else if (!should_fail_ && !extension)
     ADD_FAILURE() << "Failed to install extension";
 
   if (!extension)
     return nullptr;
 
   extension_id_ = extension->id();
-  extension = nullptr;
-  CheckPermissions(extension_id_);
+  // Trying to reload a shared module (as we do when adjusting extension
+  // permissions) causes ExtensionService to crash. Only adjust permissions for
+  // non-shared modules.
+  // TODO(devlin): That's not good; we shouldn't be crashing.
+  if (!SharedModuleInfo::IsSharedModule(extension.get())) {
+    extension = nullptr;
+    CheckPermissions(extension_id_);
+  }
 
   if (!install_param_.empty()) {
     ExtensionPrefs::Get(browser_context_)
         ->SetInstallParam(extension_id_, install_param_);
     // Reload the extension so listeners of the loaded notification have access
     // to the install param.
     TestExtensionRegistryObserver registry_observer(extension_registry_,
                                                     extension_id_);
     extension_service_->ReloadExtension(extension_id_);
     registry_observer.WaitForExtensionLoaded();
@@ skipping 143 matching lines @@
 
   std::string install_warnings_message = "Unexpected warnings for extension:\n";
   for (const InstallWarning& warning : install_warnings)
     install_warnings_message += "  " + warning.message + "\n";
 
   ADD_FAILURE() << install_warnings_message;
   return false;
 }
 
 }  // namespace extensions