Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8885)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_browsertest.h

Issue 2536903002: [Extensions WebUI] Clean up ExtensionSettingsUIBrowserTest (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
index 87718bd8066ced344a8b592bf580fab8ca6bcd98..1abb1df7e3b4e751579ea8f96ad98c5fd78b7e9f 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
+++ b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
@@ -5,16 +5,18 @@
#ifndef CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_BROWSERTEST_H_
#define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_BROWSERTEST_H_
+#include <memory>
+
+#include "base/files/file_path.h"
#include "base/macros.h"
-#include "chrome/browser/extensions/chrome_extension_test_notification_observer.h"
#include "chrome/test/base/web_ui_browser_test.h"
-#include "extensions/browser/extension_dialog_auto_confirm.h"
#include "extensions/browser/test_management_policy.h"
-#include "extensions/common/extension.h"
#include "extensions/common/feature_switch.h"
-#include "extensions/common/features/feature_channel.h"
-class Profile;
+namespace extensions {
+class Extension;
+class ScopedTestDialogAutoConfirm;
+}
// C++ test fixture used by extension_settings_browsertest.js.
class ExtensionSettingsUIBrowserTest : public WebUIBrowserTest {
@@ -23,15 +25,6 @@ class ExtensionSettingsUIBrowserTest : public WebUIBrowserTest {
~ExtensionSettingsUIBrowserTest() override;
protected:
- // Get the profile to use.
- Profile* GetProfile();
-
- const std::string& last_loaded_extension_id() {
- return observer_->last_loaded_extension_id();
- }
-
- void SetUpOnMainThread() override;
-
void InstallGoodExtension();
void InstallErrorsExtension();
@@ -55,17 +48,8 @@ class ExtensionSettingsUIBrowserTest : public WebUIBrowserTest {
void ShrinkWebContentsView();
private:
- bool WaitForExtensionViewsToLoad();
- const extensions::Extension* InstallUnpackedExtension(
- const base::FilePath& path);
const extensions::Extension* InstallExtension(const base::FilePath& path);
- std::unique_ptr<extensions::ChromeExtensionTestNotificationObserver>
- observer_;
-
- // The default profile to be used.
- Profile* profile_;
-
// Used to simulate managed extensions (by being registered as a provider).
extensions::TestManagementPolicyProvider policy_provider_;

Powered by Google App Engine
This is Rietveld 408576698