Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2536723007: Removed android scrolling fake mouse moves and device_supports_mouse (Closed)

Created:
4 years ago by amaralp
Modified:
4 years ago
CC:
agrieve+watch_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, caseq+blink_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dtapuska+blinkwatch_chromium.org, jam, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Navid Zolghadr, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed android scrolling fake mouse moves and device_supports_mouse When a user scrolls we need to generate fake mouse moves since the cursor is moving relative to the page (for example you might scroll over an element that has an mouseover event listener). Currently Android and blink have separate code-paths for generating these fake mouse moves. This CL removes the Android specific code-path and makes Android use the Blink code-path. In order to make the Blink codepath activate on Android, delete the deviceSupportsMouse websetting which was exclusively used to disable this fake-mouse-move codepath. It's sufficient to rely on mousePositionUnknown instead, which disables the codepath if no mousemove event was ever received. BUG=492738 Committed: https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702 Cr-Commit-Position: refs/heads/master@{#438691}

Patch Set 1 #

Patch Set 2 : Adding isMousePositionUnknown checks #

Patch Set 3 : Made checks mirror what previous logic #

Total comments: 14

Patch Set 4 : fixed suggestions #

Patch Set 5 : setting mouse position to unknown when dev tool touch emulator is started #

Patch Set 6 : clearing mouse event manager instead of just setting isMousePositionUnknown #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -69 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 3 4 5 6 7 8 4 chunks +0 lines, -18 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 2 3 4 5 6 7 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 1 2 3 4 5 6 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 65 (44 generated)
amaralp
PTAL
4 years ago (2016-12-01 20:25:32 UTC) #12
aelias_OOO_until_Jul13
lgtm, adding more OWNERS: avi@ for trivial content/public/common removal bokan@ for Source/core https://codereview.chromium.org/2536723007/diff/40001/third_party/WebKit/Source/web/WebSettingsImpl.h File third_party/WebKit/Source/web/WebSettingsImpl.h ...
4 years ago (2016-12-02 05:33:14 UTC) #18
Avi (use Gerrit)
lgtm Nuke away.
4 years ago (2016-12-02 15:32:48 UTC) #19
bokan
https://codereview.chromium.org/2536723007/diff/40001/third_party/WebKit/LayoutTests/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html File third_party/WebKit/LayoutTests/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html (right): https://codereview.chromium.org/2536723007/diff/40001/third_party/WebKit/LayoutTests/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html#newcode15 third_party/WebKit/LayoutTests/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html:15: window.addEventListener("mousemove", listener, false); Is there a converse test? That ...
4 years ago (2016-12-02 18:04:05 UTC) #20
amaralp
https://codereview.chromium.org/2536723007/diff/40001/third_party/WebKit/LayoutTests/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html File third_party/WebKit/LayoutTests/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html (right): https://codereview.chromium.org/2536723007/diff/40001/third_party/WebKit/LayoutTests/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html#newcode15 third_party/WebKit/LayoutTests/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html:15: window.addEventListener("mousemove", listener, false); On 2016/12/02 at 18:04:04, bokan wrote: ...
4 years ago (2016-12-02 23:00:36 UTC) #21
bokan
Sorry for delay, feel free to ping me if it takes more than 24h to ...
4 years ago (2016-12-07 00:09:53 UTC) #22
amaralp
https://codereview.chromium.org/2536723007/diff/40001/third_party/WebKit/Source/web/DevToolsEmulator.cpp File third_party/WebKit/Source/web/DevToolsEmulator.cpp (left): https://codereview.chromium.org/2536723007/diff/40001/third_party/WebKit/Source/web/DevToolsEmulator.cpp#oldcode461 third_party/WebKit/Source/web/DevToolsEmulator.cpp:461: m_webViewImpl->page()->settings().setDeviceSupportsMouse( On 2016/12/07 at 00:09:53, bokan wrote: > On ...
4 years ago (2016-12-13 01:09:14 UTC) #35
bokan
thanks, lgtm
4 years ago (2016-12-13 12:07:50 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536723007/120001
4 years ago (2016-12-13 18:51:45 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/324976)
4 years ago (2016-12-13 19:00:54 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536723007/120001
4 years ago (2016-12-13 19:45:52 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/122136) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-13 19:48:46 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536723007/140001
4 years ago (2016-12-13 20:10:36 UTC) #48
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/325079)
4 years ago (2016-12-13 20:19:49 UTC) #50
amaralp
Adding dcheng@ for SECURITY_OWNERS for content/public/common/common_param_traits.h
4 years ago (2016-12-13 23:55:06 UTC) #52
dcheng
ipc lgtm
4 years ago (2016-12-14 23:09:20 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536723007/140001
4 years ago (2016-12-14 23:11:22 UTC) #55
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/123136) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-14 23:14:13 UTC) #57
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536723007/160001
4 years ago (2016-12-14 23:18:52 UTC) #60
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years ago (2016-12-15 01:09:12 UTC) #63
commit-bot: I haz the power
4 years ago (2016-12-15 01:15:17 UTC) #65
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702
Cr-Commit-Position: refs/heads/master@{#438691}

Powered by Google App Engine
This is Rietveld 408576698