Removed android scrolling fake mouse moves and device_supports_mouse

third_party/WebKit/Source/web/DevToolsEmulator.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "web/DevToolsEmulator.h"
 
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/Settings.h"
 #include "core/frame/VisualViewport.h"
@@ skipping 72 matching lines @@
           webViewImpl->page()->settings().availableHoverTypes()),
       m_embedderPrimaryHoverType(
           webViewImpl->page()->settings().primaryHoverType()),
       m_embedderMainFrameResizesAreOrientationChanges(
           webViewImpl->page()
               ->settings()
               .mainFrameResizesAreOrientationChanges()),
       m_touchEventEmulationEnabled(false),
       m_doubleTapToZoomEnabled(false),
       m_originalTouchEventAPIEnabled(false),
-      m_originalDeviceSupportsMouse(false),
       m_originalDeviceSupportsTouch(false),
       m_originalMaxTouchPoints(0),
       m_embedderScriptEnabled(webViewImpl->page()->settings().scriptEnabled()),
       m_scriptExecutionDisabled(false) {}
 
 DevToolsEmulator::~DevToolsEmulator() {}
 
 DevToolsEmulator* DevToolsEmulator::create(WebViewImpl* webViewImpl) {
   return new DevToolsEmulator(webViewImpl);
 }
@@ skipping 337 matching lines @@
       FloatRect(m_viewportOverride->position.x, m_viewportOverride->position.y,
                 viewportSize.width(), viewportSize.height()));
 }
 
 void DevToolsEmulator::setTouchEventEmulationEnabled(bool enabled) {
   if (m_touchEventEmulationEnabled == enabled)
     return;
   if (!m_touchEventEmulationEnabled) {
     m_originalTouchEventAPIEnabled =
         RuntimeEnabledFeatures::touchEventAPIEnabled();
-    m_originalDeviceSupportsMouse =
-        m_webViewImpl->page()->settings().deviceSupportsMouse();
     m_originalDeviceSupportsTouch =
         m_webViewImpl->page()->settings().deviceSupportsTouch();
     m_originalMaxTouchPoints =
         m_webViewImpl->page()->settings().maxTouchPoints();
   }
   RuntimeEnabledFeatures::setTouchEventAPIEnabled(
       enabled ? true : m_originalTouchEventAPIEnabled);
   if (!m_originalDeviceSupportsTouch) {
-    m_webViewImpl->page()->settings().setDeviceSupportsMouse(

[bokan, 2016/12/02 18:04:05]

We should probably clear the last known mouse location here to prevent
dispatching the fake mouse moves when emulating Android.

[amaralp, 2016/12/02 23:00:36]

 I checked locally and no fake mouse moves are dispatched during emulation even
without the clearing.

[bokan, 2016/12/07 00:09:53]

Could you find out why? As far as I can tell, if the mouse moved at all on the
page before we enter emulation then we should be dispatching these. The only
place we clear the mouse location is from MouseEventManager::clear but I don't
see how we might be calling that from here.

This is actually important since devs often use emulation to build for mobile so
its important we don't break emulation.

[amaralp, 2016/12/13 01:09:14]

I'm adding a clear just in case, but from what I can tell the fake mouse event
is created but never dispatched all the way down to javascript.

-        enabled ? false : m_originalDeviceSupportsMouse);
     m_webViewImpl->page()->settings().setDeviceSupportsTouch(
         enabled ? true : m_originalDeviceSupportsTouch);
     // Currently emulation does not provide multiple touch points.
     m_webViewImpl->page()->settings().setMaxTouchPoints(
         enabled ? 1 : m_originalMaxTouchPoints);
   }
   m_touchEventEmulationEnabled = enabled;
   // TODO(dgozman): mainFrameImpl() check in this class should be unnecessary.
   // It is only needed when we reattach and restore InspectorEmulationAgent,
   // which happens before everything has been setup correctly, and therefore
@@ skipping 45 matching lines @@
       m_lastPinchAnchorCss.reset();
       m_lastPinchAnchorDip.reset();
     }
     return true;
   }
 
   return false;
 }
 
 }  // namespace blink