Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2536723005: [Findit] Fix bugs when pulling gtest result. (Closed)

Created:
4 years ago by chanli
Modified:
4 years ago
Reviewers:
stgao, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py View 1 2 chunks +12 lines, -1 line 2 comments Download
M appengine/findit/waterfall/process_swarming_task_result_pipeline.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/swarming_util.py View 2 chunks +5 lines, -1 line 0 comments Download
M appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
chanli
PTAL
4 years ago (2016-11-29 21:34:48 UTC) #2
stgao
lgtm My question could be addressed in a follow-up CL. https://codereview.chromium.org/2536723005/diff/1/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py File appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py (right): https://codereview.chromium.org/2536723005/diff/1/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py#newcode113 ...
4 years ago (2016-11-30 00:21:35 UTC) #4
chanli
Added a comment in the code
4 years ago (2016-11-30 05:55:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536723005/20001
4 years ago (2016-11-30 05:55:35 UTC) #8
stgao
https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py File appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py (right): https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py#newcode110 appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py:110: # If swarming task aborted because of errors in ...
4 years ago (2016-11-30 06:05:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/infra/infra/+/5207457dd13bac9e222bf10c7e5e33aeb399dd77
4 years ago (2016-11-30 06:10:30 UTC) #12
chanli
https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py File appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py (right): https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py#newcode110 appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py:110: # If swarming task aborted because of errors in ...
4 years ago (2016-11-30 07:13:29 UTC) #13
stgao
4 years ago (2016-11-30 17:37:39 UTC) #14
Message was sent while issue was closed.
On 2016/11/30 07:13:29, chanli wrote:
>
https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterf...
> File appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
> (right):
> 
>
https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterf...
> appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py:110:
#
> If swarming task aborted because of errors in request arguments,
> On 2016/11/30 06:05:31, stgao (slow on Monday) wrote:
> > Double check: do such cases have a specific exit code? If so, it seems
better
> to
> > handle this by line #134-137 below.
> 
> I have checked the state is STATE_COMPLETED and exit code is 1, which means it
> couldn't be differentiated with normal test failures.

thanks for checking.

Powered by Google App Engine
This is Rietveld 408576698