[Findit] Fix bugs when pulling gtest result.

[Findit] Fix bugs when pulling gtest result.

BUG=669235
Committed: https://chromium.googlesource.com/infra/infra/+/5207457dd13bac9e222bf10c7e5e33aeb399dd77

[chanli, 2016-11-29 21:34:47]

chanli@chromium.org changed reviewers:
+ lijeffrey@chromium.org

[chanli, 2016-11-29 21:34:48]

PTAL

[stgao, 2016-11-30 00:21:34]

stgao@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2016-11-30 00:21:35]

lgtm

My question could be addressed in a follow-up CL.

https://codereview.chromium.org/2536723005/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
(right):

https://codereview.chromium.org/2536723005/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py:113:
'message': 'outputs_ref is None'
In what situation there is no outputs_ref? We should find out the root cause,
and update here with a comment to explain what could have happened.

[chanli, 2016-11-30 05:55:17]

Added a comment in the code

[chanli, 2016-11-30 05:55:24]

The CQ bit was checked by chanli@chromium.org

[chanli, 2016-11-30 05:55:25]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2536723005/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-11-30 05:55:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stgao, 2016-11-30 06:05:32]

https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
(right):

https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py:110: #
If swarming task aborted because of errors in request arguments,
Double check: do such cases have a specific exit code? If so, it seems better to
handle this by line #134-137 below.

[commit-bot: I haz the power, 2016-11-30 06:10:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480485324908460,
"parent_rev": "84f32bbefda8d999df66405d1862436365b7b69c", "commit_rev":
"5207457dd13bac9e222bf10c7e5e33aeb399dd77"}

[commit-bot: I haz the power, 2016-11-30 06:10:29]

Description was changed from

==========
[Findit] Fix bugs when pulling gtest result.

BUG=669235
==========

to

==========
[Findit] Fix bugs when pulling gtest result.

BUG=669235

Committed:
https://chromium.googlesource.com/infra/infra/+/5207457dd13bac9e222bf10c7e5e3...
==========

[commit-bot: I haz the power, 2016-11-30 06:10:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/5207457dd13bac9e222bf10c7e5e3...

[chanli, 2016-11-30 07:13:29]

https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
(right):

https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py:110: #
If swarming task aborted because of errors in request arguments,
On 2016/11/30 06:05:31, stgao (slow on Monday) wrote:
> Double check: do such cases have a specific exit code? If so, it seems better
to
> handle this by line #134-137 below.

I have checked the state is STATE_COMPLETED and exit code is 1, which means it
couldn't be differentiated with normal test failures.

[stgao, 2016-11-30 17:37:39]

On 2016/11/30 07:13:29, chanli wrote:
>
https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterf...
> File appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
> (right):
> 
>
https://codereview.chromium.org/2536723005/diff/20001/appengine/findit/waterf...
> appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py:110:
#
> If swarming task aborted because of errors in request arguments,
> On 2016/11/30 06:05:31, stgao (slow on Monday) wrote:
> > Double check: do such cases have a specific exit code? If so, it seems
better
> to
> > handle this by line #134-137 below.
> 
> I have checked the state is STATE_COMPLETED and exit code is 1, which means it
> couldn't be differentiated with normal test failures.

thanks for checking.