[Findit] Fix bugs when pulling gtest result.

appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import datetime
 import logging
 import time
 
 from common.http_client_appengine import HttpClientAppengine as HttpClient
@@ skipping 61 matching lines @@
   def _MonitorSwarmingTask(self, task_id, *call_args):
     """Monitors the swarming task and waits for it to complete."""
     assert task_id
     timeout_hours = waterfall_config.GetSwarmingSettings().get(
         'task_timeout_hours')
     deadline = time.time() + timeout_hours * 60 * 60
     server_query_interval_seconds = waterfall_config.GetSwarmingSettings().get(
         'server_query_interval_seconds')
     task_started = False
     task_completed = False
-    tests_statuses = {}
     step_name_no_platform = None
     task = self._GetSwarmingTask(*call_args)
 
     while not task_completed:
       data, error = swarming_util.GetSwarmingTaskResultById(
           task_id, self.HTTP_CLIENT)
 
       if error:
         # An error occurred when trying to contact the swarming server.
         task.status = analysis_status.ERROR
         task.error = error
         task.put()
         break
 
       task_state = data['state']
       exit_code = (data.get('exit_code') if
                    task_state == swarming_util.STATE_COMPLETED else None)
       step_name_no_platform = (
           step_name_no_platform or swarming_util.GetTagValue(
               data.get('tags', {}), 'ref_name'))
 
       if task_state not in swarming_util.STATES_RUNNING:
         task_completed = True
 
         if (task_state == swarming_util.STATE_COMPLETED and
             int(exit_code) != swarming_util.TASK_FAILED):
           outputs_ref = data.get('outputs_ref')
+
+          # If swarming task aborted because of errors in request arguments,

[stgao, 2016/11/30 06:05:31]

Double check: do such cases have a specific exit code? If so, it seems better to
handle this by line #134-137 below.

[chanli, 2016/11/30 07:13:29]

I have checked the state is STATE_COMPLETED and exit code is 1, which means it
couldn't be differentiated with normal test failures.

+          # it's possible that there is no outputs_ref.
+          if not outputs_ref:
+            task.status = analysis_status.ERROR
+            task.error = {
+              'code': swarming_util.NO_TASK_OUTPUTS,
+              'message': 'outputs_ref is None'
+            }
+            task.put()
+            break
+
           output_json, error = swarming_util.GetSwarmingTaskFailureLog(
               outputs_ref, self.HTTP_CLIENT)
 
           if error:
             task.status = analysis_status.ERROR
             task.error = error
           else:
             task.status = analysis_status.COMPLETED
 
           tests_statuses = self._CheckTestsRunStatuses(output_json, *call_args)
@@ skipping 72 matching lines @@
       task_id (str): The task id to query the swarming server on the progresss
         of a swarming task.
 
     Returns:
       A dict of lists for reliable/flaky tests.
     """
     call_args = self._GetArgs(master_name, builder_name, build_number,
                               step_name, *args)
     step_name_no_platform = self._MonitorSwarmingTask(task_id, *call_args)
     return step_name, step_name_no_platform