[Findit] Fix bugs when pulling gtest result.

appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py

Index: appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
diff --git a/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py b/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
index bae4096c6d5d0edd8e7bb787c44c99a1db310b93..293ed423a655e414dee66372d54926bc2df5d571 100644
--- a/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
+++ b/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
@@ -79,7 +79,6 @@ class ProcessBaseSwarmingTaskResultPipeline(BasePipeline):
         'server_query_interval_seconds')
     task_started = False
     task_completed = False
-    tests_statuses = {}
     step_name_no_platform = None
     task = self._GetSwarmingTask(*call_args)
 
@@ -107,6 +106,18 @@ class ProcessBaseSwarmingTaskResultPipeline(BasePipeline):
         if (task_state == swarming_util.STATE_COMPLETED and
             int(exit_code) != swarming_util.TASK_FAILED):
           outputs_ref = data.get('outputs_ref')
+
+          # If swarming task aborted because of errors in request arguments,

[stgao, 2016/11/30 06:05:31]

Double check: do such cases have a specific exit code? If so, it seems better to
handle this by line #134-137 below.

[chanli, 2016/11/30 07:13:29]

I have checked the state is STATE_COMPLETED and exit code is 1, which means it
couldn't be differentiated with normal test failures.

+          # it's possible that there is no outputs_ref.
+          if not outputs_ref:
+            task.status = analysis_status.ERROR
+            task.error = {
+              'code': swarming_util.NO_TASK_OUTPUTS,
+              'message': 'outputs_ref is None'
+            }
+            task.put()
+            break
+
           output_json, error = swarming_util.GetSwarmingTaskFailureLog(
               outputs_ref, self.HTTP_CLIENT)