Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable.html

Issue 2536563003: Fix missing warning for canceling touchmove when in default not passive mode. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <script src="../../../resources/js-test.js"></script> 1 <!DOCTYPE html>
2 <script src='../../../resources/testharness.js'></script>
3 <script src='../../../resources/testharnessreport.js'></script>
2 4
3 <p id="description"></p> 5 <style>
4 <div id="console"></div> 6 #first {width: 100px; height: 50px; }
5 <script type="text/javascript"> 7 </style>
6 description('Test that touch events may or may not be marked cancelable. http:// crbug.com/365681');
7 8
8 var gotTouchMove = false; 9 <body>
9 var touchEvent; 10 <div id=first />
10 11
11 document.addEventListener('touchmove', function(event) { 12 <script>
12 shouldBeFalse('gotTouchMove'); 13 test(function() {
13 gotTouchMove = true; 14 var gotTouchMove = false;
14 touchEvent = event; 15 var touchEvent;
15 shouldBeFalse('touchEvent.defaultPrevented'); 16 var handler = function(event) {
16 console.log('Calling preventDefault on TouchEvent with cancelable=' + event. cancelable); 17 assert_false(gotTouchMove);
17 touchEvent.preventDefault(); 18 gotTouchMove = true;
18 }, {passive: false}); 19 touchEvent = event;
20 assert_false(touchEvent.defaultPrevented);
21 console.log('Calling preventDefault on TouchEvent with cancelable=' + even t.cancelable);
22 touchEvent.preventDefault();
23 };
19 24
20 if (window.eventSender) { 25 document.addEventListener('touchmove', handler, {passive: false});
21 eventSender.addTouchPoint(152, 152);
22 eventSender.touchStart();
23 26
24 eventSender.updateTouchPoint(0, 155, 155); 27 eventSender.addTouchPoint(152, 152);
25 eventSender.setTouchCancelable(true); 28 eventSender.touchStart();
26 debug('Sending cancelable touchmove');
27 eventSender.touchMove();
28 shouldBeTrue('gotTouchMove');
29 shouldBeTrue('touchEvent.cancelable');
30 shouldBeTrue('touchEvent.defaultPrevented');
31 gotTouchMove = false;
32 29
33 debug(''); 30 eventSender.updateTouchPoint(0, 155, 155);
34 debug('Sending uncancelable touchmove'); 31 eventSender.setTouchCancelable(true);
35 eventSender.setTouchCancelable(false); 32 console.log('Sending cancelable touchmove');
36 eventSender.updateTouchPoint(0, 160, 160); 33 eventSender.touchMove();
37 eventSender.touchMove(); 34 assert_true(gotTouchMove, "Got touch move");
38 shouldBeTrue('gotTouchMove'); 35 assert_true(touchEvent.cancelable, "Event was cancelable");
39 shouldBeFalse('touchEvent.cancelable'); 36 assert_true(touchEvent.defaultPrevented, "Event was prevented");
40 shouldBeFalse('touchEvent.defaultPrevented'); 37 gotTouchMove = false;
41 } else { 38
42 debug('This test requires --run-layout-test.'); 39 console.log('Sending uncancelable touchmove');
43 } 40 eventSender.setTouchCancelable(false);
41 eventSender.updateTouchPoint(0, 160, 160);
42 eventSender.touchMove();
43 assert_true(gotTouchMove, "Got touch move");
44 assert_false(touchEvent.cancelable, "Event was not cancelable");
45 assert_false(touchEvent.defaultPrevented, "Event was not prevented");
46 document.removeEventListener('touchmove', handler);
47 eventSender.clearTouchPoints();
48
49 }, 'Test that touch events may or may not be marked cancelable. http://crbug.com /365681');
50
51 test(function() {
52 var gotTouchMove = false;
53 var touchEvent;
54 var handler = function(event) {
55 gotTouchMove = true;
56 touchEvent = event;
57 console.log('touch mnove');
58 event.preventDefault();
59 };
60 eventSender.addTouchPoint(15, 15);
61 eventSender.touchStart();
62 document.getElementById('first').addEventListener('touchmove', handler);
63 eventSender.setTouchCancelable(false);
64 eventSender.updateTouchPoint(0, 30, 30);
65 console.log('Sending cancelable touchmove');
Rick Byers 2016/11/28 18:42:35 nit: fix log message (I was confused by the output
66 eventSender.touchMove();
67 assert_true(gotTouchMove, "Got touch move");
68 assert_false(touchEvent.cancelable, "Event was not cancelable");
69 assert_false(touchEvent.defaultPrevented, "Event was not prevented");
70
71 }, 'Test that warning occurs in default mode');
44 72
45 </script> 73 </script>
74 </body>
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698