Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 2536073002: DevTools: [Console] migrate message level icons to UI.Icon (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Console] migrate message level icons to UI.Icon BUG=669323 R=dgozman Committed: https://crrev.com/efdbd73f4c10f4a70428891a1070fcff46143e88 Cr-Commit-Position: refs/heads/master@{#434878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -43 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 4 chunks +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/consoleView.css View 3 chunks +9 lines, -43 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
lushnikov
please, take a look
4 years ago (2016-11-29 01:46:52 UTC) #1
dgozman
Nice! lgtm
4 years ago (2016-11-29 02:09:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536073002/1
4 years ago (2016-11-29 03:47:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 03:53:33 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-29 03:57:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efdbd73f4c10f4a70428891a1070fcff46143e88
Cr-Commit-Position: refs/heads/master@{#434878}

Powered by Google App Engine
This is Rietveld 408576698