Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2536073002: DevTools: [Console] migrate message level icons to UI.Icon (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/consoleView.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 8365d8f3d18cd21a51e7431ec6bf9464c3e77a08..88597110af88c8ef76d1eb1edf023f5a023607dc 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -48,6 +48,8 @@ Console.ConsoleViewMessage = class {
this._dataGrid = null;
this._previewFormatter = new Components.RemoteObjectPreviewFormatter();
this._searchRegex = null;
+ /** @type {?UI.Icon} */
+ this._messageLevelIcon = null;
}
/**
@@ -937,6 +939,8 @@ Console.ConsoleViewMessage = class {
return this._contentElement;
var contentElement = createElementWithClass('div', 'console-message');
+ if (this._messageLevelIcon)
+ contentElement.appendChild(this._messageLevelIcon);
this._contentElement = contentElement;
if (this._message.type === SDK.ConsoleMessage.MessageType.StartGroup ||
this._message.type === SDK.ConsoleMessage.MessageType.StartGroupCollapsed)
@@ -991,21 +995,27 @@ Console.ConsoleViewMessage = class {
switch (this._message.level) {
case SDK.ConsoleMessage.MessageLevel.Log:
this._element.classList.add('console-log-level');
+ this._updateMessageLevelIcon('');
break;
case SDK.ConsoleMessage.MessageLevel.Debug:
this._element.classList.add('console-debug-level');
+ this._updateMessageLevelIcon('');
break;
case SDK.ConsoleMessage.MessageLevel.Warning:
this._element.classList.add('console-warning-level');
+ this._updateMessageLevelIcon('smallicon-warning');
break;
case SDK.ConsoleMessage.MessageLevel.Error:
this._element.classList.add('console-error-level');
+ this._updateMessageLevelIcon('smallicon-error');
break;
case SDK.ConsoleMessage.MessageLevel.RevokedError:
this._element.classList.add('console-revokedError-level');
+ this._updateMessageLevelIcon('smallicon-revoked-error');
break;
case SDK.ConsoleMessage.MessageLevel.Info:
this._element.classList.add('console-info-level');
+ this._updateMessageLevelIcon('smallicon-info');
break;
}
@@ -1015,6 +1025,20 @@ Console.ConsoleViewMessage = class {
}
/**
+ * @param {string} iconType
+ */
+ _updateMessageLevelIcon(iconType) {
+ if (!iconType && !this._messageLevelIcon)
+ return;
+ if (iconType && !this._messageLevelIcon) {
+ this._messageLevelIcon = UI.Icon.create('', 'message-level-icon');
+ if (this._contentElement)
+ this._contentElement.insertBefore(this._messageLevelIcon, this._contentElement.firstChild);
+ }
+ this._messageLevelIcon.setIconType(iconType);
+ }
+
+ /**
* @return {number}
*/
repeatCount() {
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/consoleView.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698