Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2538673002: DevTools: [Console] migrate all of the smallIcons in consoleView.css (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Console] migrate all of the smallIcons in consoleView.css This patch migrates all of the smallIcons usages in consoleView.css onto UI.Icon. BUG=669323 R=dgozman Committed: https://crrev.com/98a1848c85bc3fdcfe6b8f0f66a6fab433d1c1a0 Cr-Commit-Position: refs/heads/master@{#434924}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebaseline test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -77 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-tests-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/consoleView.css View 5 chunks +9 lines, -72 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
lushnikov
please, take a look
4 years ago (2016-11-29 04:10:30 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2538673002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/2538673002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js#newcode1261 third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1261: if (this.consoleMessage().level === SDK.ConsoleMessage.MessageLevel.Log) { Looking at css, ...
4 years ago (2016-11-29 04:22:03 UTC) #4
lushnikov
Thanks! https://codereview.chromium.org/2538673002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/2538673002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js#newcode1261 third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1261: if (this.consoleMessage().level === SDK.ConsoleMessage.MessageLevel.Log) { On 2016/11/29 04:22:03, ...
4 years ago (2016-11-29 06:17:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538673002/20001
4 years ago (2016-11-29 06:17:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 07:39:59 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-29 07:41:47 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98a1848c85bc3fdcfe6b8f0f66a6fab433d1c1a0
Cr-Commit-Position: refs/heads/master@{#434924}

Powered by Google App Engine
This is Rietveld 408576698