Issue 2535753006: Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames method. No behavior chang…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2535753006: Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames method. No behavior chang… (Closed)

Created:
4 years ago by Victor Vasiliev

Modified:
4 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames method. No behavior change. MaybeRemoveRetransmittableFrames is only called from inside RemoveRetransmittability, and it unconditionally removes frames, no "maybe" about it :-) Merge internal change: 139571201 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -15 lines)			Patch
	M	net/quic/core/quic_unacked_packet_map.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	net/quic/core/quic_unacked_packet_map.cc	View		2 chunks	+8 lines, -12 lines	0 comments	Download

Depends on Patchset:

Issue 2543833003 Patch 1

Dependent Patchsets:

Issue 2541233002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages