Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: net/quic/core/quic_unacked_packet_map.h

Issue 2535753006: Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames method. No behavior chang… (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/core/quic_unacked_packet_map.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_QUIC_UNACKED_PACKET_MAP_H_ 5 #ifndef NET_QUIC_QUIC_UNACKED_PACKET_MAP_H_
6 #define NET_QUIC_QUIC_UNACKED_PACKET_MAP_H_ 6 #define NET_QUIC_QUIC_UNACKED_PACKET_MAP_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <deque> 10 #include <deque>
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 private: 150 private:
151 // Called when a packet is retransmitted with a new packet number. 151 // Called when a packet is retransmitted with a new packet number.
152 // |old_packet_number| will remain unacked, but will have no 152 // |old_packet_number| will remain unacked, but will have no
153 // retransmittable data associated with it. Retransmittable frames will be 153 // retransmittable data associated with it. Retransmittable frames will be
154 // transferred to |info| and all_transmissions will be populated. 154 // transferred to |info| and all_transmissions will be populated.
155 void TransferRetransmissionInfo(QuicPacketNumber old_packet_number, 155 void TransferRetransmissionInfo(QuicPacketNumber old_packet_number,
156 QuicPacketNumber new_packet_number, 156 QuicPacketNumber new_packet_number,
157 TransmissionType transmission_type, 157 TransmissionType transmission_type,
158 QuicTransmissionInfo* info); 158 QuicTransmissionInfo* info);
159 159
160 void MaybeRemoveRetransmittableFrames(
161 QuicTransmissionInfo* transmission_info);
162
163 // Returns true if packet may be useful for an RTT measurement. 160 // Returns true if packet may be useful for an RTT measurement.
164 bool IsPacketUsefulForMeasuringRtt(QuicPacketNumber packet_number, 161 bool IsPacketUsefulForMeasuringRtt(QuicPacketNumber packet_number,
165 const QuicTransmissionInfo& info) const; 162 const QuicTransmissionInfo& info) const;
166 163
167 // Returns true if packet may be useful for congestion control purposes. 164 // Returns true if packet may be useful for congestion control purposes.
168 bool IsPacketUsefulForCongestionControl( 165 bool IsPacketUsefulForCongestionControl(
169 const QuicTransmissionInfo& info) const; 166 const QuicTransmissionInfo& info) const;
170 167
171 // Returns true if packet may be associated with retransmittable data 168 // Returns true if packet may be associated with retransmittable data
172 // directly or through retransmissions. 169 // directly or through retransmissions.
(...skipping 24 matching lines...) Expand all
197 QuicByteCount bytes_in_flight_; 194 QuicByteCount bytes_in_flight_;
198 // Number of retransmittable crypto handshake packets. 195 // Number of retransmittable crypto handshake packets.
199 size_t pending_crypto_packet_count_; 196 size_t pending_crypto_packet_count_;
200 197
201 DISALLOW_COPY_AND_ASSIGN(QuicUnackedPacketMap); 198 DISALLOW_COPY_AND_ASSIGN(QuicUnackedPacketMap);
202 }; 199 };
203 200
204 } // namespace net 201 } // namespace net
205 202
206 #endif // NET_QUIC_QUIC_UNACKED_PACKET_MAP_H_ 203 #endif // NET_QUIC_QUIC_UNACKED_PACKET_MAP_H_
OLDNEW
« no previous file with comments | « no previous file | net/quic/core/quic_unacked_packet_map.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698