Issue 2543833003: Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as it will always be …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2543833003: Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as it will always be … (Closed)

Created:
4 years ago by Victor Vasiliev

Modified:
4 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as it will always be a no-op/early return. No behavior change. Calling SetMaxPacketLength with max_packet_length_ as the argument hits the early return here: https://chromium.googlesource.com/chromium/src/+/bdbe864eb7ecdf545a6f6a63b635466f9c9465da/net/quic/core/quic_packet_creator.cc#74 Merge internal change: 139571059 R=rch@chromium.org BUG=

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	net/quic/core/quic_packet_creator.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 2 (0 generated)

lgtm