Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 25353009: telemetry: Refactored rasterize_and_record measurement. (Closed)

Created:
7 years, 2 months ago by ernstm
Modified:
7 years, 2 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

telemetry: Refactored rasterize_and_record measurement. - switched rasterize_and_record benchmark to new benchmark architecture. - detailled traces are not required anymore, fixing the issue with trace event buffer overflows. - changed output to show pixels rasterized and recorded for one iteration of the raster/record loop. - Further reduced variance by excluding lowres tiles and adding another sleep to the measurement. Stdev of pixel counts is now zero (except for amazon.com). Stdev of time metrics with 100 repetitions is well below 1% of the mean for most pages in the top_25. R=nduca@chromium.org BUG=280638 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228253

Patch Set 1 #

Patch Set 2 : Moved issuing of trace events to benchmark_instrumentation + rebase. #

Patch Set 3 : Made BenchmarkInstrumentation a class. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -208 lines) Patch
M cc/cc.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/debug/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M cc/debug/benchmark_instrumentation.h View 1 2 1 chunk +10 lines, -20 lines 0 comments Download
A cc/debug/benchmark_instrumentation.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M cc/debug/rendering_stats.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M cc/debug/rendering_stats.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download
M cc/debug/rendering_stats_instrumentation.h View 1 3 chunks +3 lines, -11 lines 0 comments Download
M cc/layers/picture_layer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/resources/picture.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M cc/resources/picture.cc View 1 5 chunks +12 lines, -17 lines 0 comments Download
M cc/resources/picture_pile.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M cc/resources/picture_pile_impl.cc View 1 3 chunks +3 lines, -6 lines 0 comments Download
M cc/resources/raster_worker_pool.cc View 1 3 chunks +16 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M cc/trees/thread_proxy.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M tools/perf/measurements/rasterize_and_record.py View 1 3 chunks +19 lines, -109 lines 0 comments Download
M tools/perf/metrics/rendering_stats.py View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ernstm
7 years, 2 months ago (2013-10-04 18:31:55 UTC) #1
ernstm
Ping
7 years, 2 months ago (2013-10-08 18:50:39 UTC) #2
nduca
lgtm but maybe move the full issuance of the trace event to the guarded header.
7 years, 2 months ago (2013-10-08 23:19:47 UTC) #3
ernstm
James, could you please take a look the (minor) changes in content/renderer?
7 years, 2 months ago (2013-10-09 20:43:18 UTC) #4
ernstm
Jochen, we need an OWNER's review for the small changes to content/renderer. Could you please ...
7 years, 2 months ago (2013-10-10 18:01:55 UTC) #5
jochen (gone - plz use gerrit)
content/renderer lgtm
7 years, 2 months ago (2013-10-11 18:35:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/25353009/12001
7 years, 2 months ago (2013-10-11 18:57:54 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-11 21:12:36 UTC) #8
Message was sent while issue was closed.
Change committed as 228253

Powered by Google App Engine
This is Rietveld 408576698