Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: cc/debug/rendering_stats_instrumentation.h

Issue 25353009: telemetry: Refactored rasterize_and_record measurement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made BenchmarkInstrumentation a class. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/debug/rendering_stats.cc ('k') | cc/layers/picture_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/debug/rendering_stats_instrumentation.h
diff --git a/cc/debug/rendering_stats_instrumentation.h b/cc/debug/rendering_stats_instrumentation.h
index fcecb371cfb4bf497039c80c1dd6de04cd8022b7..4508600ea92d6a8f085c13abf43c2eeee8cb39c8 100644
--- a/cc/debug/rendering_stats_instrumentation.h
+++ b/cc/debug/rendering_stats_instrumentation.h
@@ -19,11 +19,11 @@ class CC_EXPORT RenderingStatsInstrumentation {
virtual ~RenderingStatsInstrumentation();
// Return current main thread rendering stats.
- MainThreadRenderingStats GetMainThreadRenderingStats() {
+ const MainThreadRenderingStats& main_thread_rendering_stats() {
return main_stats_;
}
// Return current impl thread rendering stats.
- ImplThreadRenderingStats GetImplThreadRenderingStats() {
+ const ImplThreadRenderingStats& impl_thread_rendering_stats() {
return impl_stats_;
}
// Return the accumulated, combined rendering stats.
@@ -36,15 +36,6 @@ class CC_EXPORT RenderingStatsInstrumentation {
// clear current stats.
void AccumulateAndClearImplThreadStats();
- // Issue trace event for current main thread rendering stats.
- void IssueTraceEventForMainThreadStats() {
- main_stats_.IssueTraceEvent();
- }
- // Issue trace event for current impl thread rendering stats.
- void IssueTraceEventForImplThreadStats() {
- impl_stats_.IssueTraceEvent();
- }
-
// Read and write access to the record_rendering_stats_ flag is not locked to
// improve performance. The flag is commonly turned off and hardly changes
// it's value during runtime.
@@ -66,6 +57,7 @@ class CC_EXPORT RenderingStatsInstrumentation {
RenderingStatsInstrumentation();
private:
+ // TODO(ernstm): rename to *_thread_rendering_stats_*
MainThreadRenderingStats main_stats_;
MainThreadRenderingStats main_stats_accu_;
ImplThreadRenderingStats impl_stats_;
« no previous file with comments | « cc/debug/rendering_stats.cc ('k') | cc/layers/picture_layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698