Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2996)

Unified Diff: cc/debug/benchmark_instrumentation.h

Issue 25353009: telemetry: Refactored rasterize_and_record measurement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made BenchmarkInstrumentation a class. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/debug/OWNERS ('k') | cc/debug/benchmark_instrumentation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/debug/benchmark_instrumentation.h
diff --git a/cc/debug/benchmark_instrumentation.h b/cc/debug/benchmark_instrumentation.h
index 615fbe90622c12a4314b118585364ef675bb1472..2614814914c25363f4d02d01cf92a759db7b49da 100644
--- a/cc/debug/benchmark_instrumentation.h
+++ b/cc/debug/benchmark_instrumentation.h
@@ -5,28 +5,18 @@
#ifndef CC_DEBUG_BENCHMARK_INSTRUMENTATION_H_
#define CC_DEBUG_BENCHMARK_INSTRUMENTATION_H_
-#include "base/debug/trace_event.h"
+#include "cc/debug/rendering_stats.h"
namespace cc {
-namespace benchmark_instrumentation {
-// Please do not change the string constants in this file (or the TRACE_EVENT
-// calls that use them) without updating
-// tools/perf/measurements/rasterize_and_record_benchmark.py accordingly.
-// The benchmark searches for events and their arguments by name.
-const char kCategory[] = "cc,benchmark";
-const char kSourceFrameNumber[] = "source_frame_number";
-const char kData[] = "data";
-const char kWidth[] = "width";
-const char kHeight[] = "height";
-const char kNumPixelsRasterized[] = "num_pixels_rasterized";
-const char kLayerTreeHostUpdateLayers[] = "LayerTreeHost::UpdateLayers";
-const char kPictureLayerUpdate[] = "PictureLayer::Update";
-const char kRunRasterOnThread[] = "RasterWorkerPoolTaskImpl::RunRasterOnThread";
-const char kRecordLoop[] = "RecordLoop";
-const char kRasterLoop[] = "RasterLoop";
-const char kPictureRecord[] = "Picture::Record";
-const char kPictureRaster[] = "Picture::Raster";
-} // namespace benchmark_instrumentation
+
+class CC_EXPORT BenchmarkInstrumentation {
+ public:
+ static void IssueMainThreadRenderingStatsEvent(
+ const MainThreadRenderingStats& stats);
+ static void IssueImplThreadRenderingStatsEvent(
+ const ImplThreadRenderingStats& stats);
+};
+
} // namespace cc
#endif // CC_DEBUG_BENCHMARK_INSTRUMENTATION_H_
« no previous file with comments | « cc/debug/OWNERS ('k') | cc/debug/benchmark_instrumentation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698