Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5940)

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

Issue 253493005: [Mac] Allow fullscreen transitions while constrained windows are open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove chrome::IndexOfFirstBlockedTab() Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm
index b36e5966f70e11899ef3af13555e37b9300d8ec1..76593a33682b979cde5cdc6119ca341fe90f1d69 100644
--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm
+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm
@@ -4,10 +4,8 @@
#include "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h"
-#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_window.h"
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
@@ -157,16 +155,3 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowMacTest, TabClose) {
TabStripModel::CLOSE_USER_GESTURE));
EXPECT_EQ(1, tab_strip->count());
}
-
-// Test that adding a sheet disables fullscreen.
-IN_PROC_BROWSER_TEST_F(ConstrainedWindowMacTest, Fullscreen) {
- EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
-
- // Dialog will delete it self when closed.
- NiceMock<ConstrainedWindowDelegateMock> delegate;
- ConstrainedWindowMac dialog(&delegate, tab1_, sheet_);
-
- EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
-
- dialog.CloseWebContentsModalDialog();
-}
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.mm ('k') | chrome/browser/ui/tabs/tab_strip_model_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698