[Mac] Allow fullscreen transitions while constrained windows are open.

chrome/browser/ui/browser_command_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_command_controller.h"
 
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 1242 matching lines @@
   command_updater_.UpdateCommandEnabled(IDC_EDIT_SEARCH_ENGINES, show_main_ui);
   command_updater_.UpdateCommandEnabled(IDC_VIEW_PASSWORDS, show_main_ui);
   command_updater_.UpdateCommandEnabled(IDC_ABOUT, show_main_ui);
   command_updater_.UpdateCommandEnabled(IDC_SHOW_APP_MENU, show_main_ui);
 #if defined (ENABLE_PROFILING) && !defined(NO_TCMALLOC)
   command_updater_.UpdateCommandEnabled(IDC_PROFILING_ENABLED, show_main_ui);
 #endif
 
   // Disable explicit fullscreen toggling when in metro snap mode.
   bool fullscreen_enabled = window_state != WINDOW_STATE_METRO_SNAP;
-#if defined(OS_MACOSX)
-  // The Mac implementation doesn't support switching to fullscreen while
-  // a tab modal dialog is displayed.
-  int tab_index = chrome::IndexOfFirstBlockedTab(browser_->tab_strip_model());

[Avi (use Gerrit), 2014/04/26 00:01:28]

This was the only use of IndexOfFirstBlockedTab. Remove that functionality from
tab_strip_model_utils.

[miu, 2014/04/26 01:07:03]

Done.

-  bool has_blocked_tab = tab_index != browser_->tab_strip_model()->count();
-  fullscreen_enabled &= !has_blocked_tab;
-#else
+#if !defined(OS_MACOSX)

[Avi (use Gerrit), 2014/04/26 00:01:28]

This is wrong. This breaks kFullscreenAllowed for non-Macs. Remove this if
entirely.

[Avi (use Gerrit), 2014/04/26 00:22:42]

Sorry, I misread this; I'm wrong here.

Though we still want to drop this #if so that the Mac also obeys the
kFullscreenAllowed pref.

[miu, 2014/04/26 01:07:03]

Yes, this looked wrong to me too.  However, when I remove it, the Mac fullscreen
controls become completely ineffective.

Looking at source control history, r219482 is responsible for it.  Throughout
that change, bartfab@ put the #if !defined(MAC_OSX) in a bunch of other places
too.  There must be a reason the fullscreen prefs don't apply for Mac.

Whether this should be fixed or not, I feel it's best to keep the scope of this
change as small as possible (in case we merge into M35), so I've left this
alone.

[Avi (use Gerrit), 2014/04/26 02:49:28]

Weird.

OK, then.

   if (window_state == WINDOW_STATE_NOT_FULLSCREEN &&
       !profile()->GetPrefs()->GetBoolean(prefs::kFullscreenAllowed)) {
     // Disable toggling into fullscreen mode if disallowed by pref.
     fullscreen_enabled = false;
   }
 #endif
 
   command_updater_.UpdateCommandEnabled(IDC_FULLSCREEN, fullscreen_enabled);
   command_updater_.UpdateCommandEnabled(IDC_PRESENTATION_MODE,
                                         fullscreen_enabled);
@@ skipping 87 matching lines @@
 
 BrowserWindow* BrowserCommandController::window() {
   return browser_->window();
 }
 
 Profile* BrowserCommandController::profile() {
   return browser_->profile();
 }
 
 }  // namespace chrome