Issue 253493003: Mojo: Windows: Enable Channel::Shutdown() on fatal error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 253493003: Mojo: Windows: Enable Channel::Shutdown() on fatal error. (Closed)

Created:
6 years, 8 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Windows: Enable Channel::Shutdown() on fatal error. r266056 (crbug.com/366768) fixed the nested deletion bug. R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266227

Patch Set 1 #

Patch Set 2 : don't reenable tests #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	mojo/system/channel.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

On 2014/04/25 04:04:36, viettrungluu wrote: Gah, tests still seem to be failing. :(

6 years, 8 months ago (2014-04-25 15:27:08 UTC) #2

viettrungluu

On 2014/04/25 15:27:08, viettrungluu wrote: > On 2014/04/25 04:04:36, viettrungluu wrote: > > Gah, tests ...

6 years, 8 months ago (2014-04-25 15:36:33 UTC) #3

viettrungluu

6 years, 8 months ago (2014-04-25 20:02:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r266227 (presubmit successful).

Expand Messages | Collapse Messages