Mojo: Windows: Enable Channel::Shutdown() on fatal error.

mojo/system/channel.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/system/channel.h"
 
 #include <algorithm>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
-#include "build/build_config.h"  // TODO(vtl): Remove this.
 #include "mojo/system/message_pipe_endpoint.h"
 
 namespace mojo {
 namespace system {
 
 COMPILE_ASSERT(Channel::kBootstrapEndpointId !=
                    MessageInTransit::kInvalidEndpointId,
                kBootstrapEndpointId_is_invalid);
 
 STATIC_CONST_MEMBER_DEFINITION const MessageInTransit::EndpointId
@@ skipping 258 matching lines @@
     default:
       HandleRemoteError(base::StringPrintf(
           "Received message of invalid type %u",
           static_cast<unsigned>(message_view.type())));
       break;
   }
 }
 
 void Channel::OnFatalError(FatalError fatal_error) {
   LOG(ERROR) << "RawChannel fatal error (type " << fatal_error << ")";
-  // TODO(vtl): We have some nested-deletion bugs on Windows, so this crashes.
-#if defined(OS_WIN)
-  LOG(ERROR) << "Not shutting down due Windows-only bug";
-#else
   Shutdown();
-#endif
 }
 
 bool Channel::ValidateReadMessage(const MessageInTransit::View& message_view) {
   const char* error_message = NULL;
   if (!message_view.IsValid(&error_message)) {
     DCHECK(error_message);
     HandleRemoteError(error_message);
     return false;
   }
 
@@ skipping 170 matching lines @@
   // TODO(vtl): Is this how we really want to handle this?
   // Sometimes we'll want to propagate the error back to the message pipe
   // (endpoint), and notify it that the remote is (effectively) closed.
   // Sometimes we'll want to kill the channel (and notify all the endpoints that
   // their remotes are dead.
   LOG(WARNING) << error_message;
 }
 
 }  // namespace system
 }  // namespace mojo