Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: mojo/system/channel.cc

Issue 253493003: Mojo: Windows: Enable Channel::Shutdown() on fatal error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: don't reenable tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/channel.cc
diff --git a/mojo/system/channel.cc b/mojo/system/channel.cc
index b0b9df93cf0c569fbe48e160e03decebe4cd0373..2669a87eb8576313a96fed18b28c7db0f272d65b 100644
--- a/mojo/system/channel.cc
+++ b/mojo/system/channel.cc
@@ -11,7 +11,6 @@
#include "base/compiler_specific.h"
#include "base/logging.h"
#include "base/strings/stringprintf.h"
-#include "build/build_config.h" // TODO(vtl): Remove this.
#include "mojo/system/message_pipe_endpoint.h"
namespace mojo {
@@ -290,12 +289,7 @@ void Channel::OnReadMessage(const MessageInTransit::View& message_view) {
void Channel::OnFatalError(FatalError fatal_error) {
LOG(ERROR) << "RawChannel fatal error (type " << fatal_error << ")";
- // TODO(vtl): We have some nested-deletion bugs on Windows, so this crashes.
-#if defined(OS_WIN)
- LOG(ERROR) << "Not shutting down due Windows-only bug";
-#else
Shutdown();
-#endif
}
bool Channel::ValidateReadMessage(const MessageInTransit::View& message_view) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698