Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2534813002: [test] Don't run presubmit over deleted files. (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Don't run presubmit over deleted files. BUG=v8:5603 NOTRY=true Committed: https://crrev.com/c69f8fbd78a973e80bd670d0fc643512e4ac9986 Cr-Commit-Position: refs/heads/master@{#41297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M PRESUBMIT.py View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/presubmit.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-11-28 08:26:12 UTC) #3
Yang
On 2016/11/28 08:26:12, jochen wrote: > lgtm Lgtm
4 years ago (2016-11-28 08:27:16 UTC) #4
Michael Achenbach
PTAL. This removes the late "isfile" check and instead only passes files that still exist. ...
4 years ago (2016-11-28 08:27:20 UTC) #5
Michael Achenbach
hey - you guys are fast :)
4 years ago (2016-11-28 08:27:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534813002/1
4 years ago (2016-11-28 08:28:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 08:30:18 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 08:30:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c69f8fbd78a973e80bd670d0fc643512e4ac9986
Cr-Commit-Position: refs/heads/master@{#41297}

Powered by Google App Engine
This is Rietveld 408576698