tools/presubmit.py - Issue 2534813002: [test] Don't run presubmit over deleted files. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(27)

My Issues | Starred Open | Closed | All

Unified Diff: tools/presubmit.py

Issue 2534813002: [test] Don't run presubmit over deleted files. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « PRESUBMIT.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/presubmit.py

diff --git a/tools/presubmit.py b/tools/presubmit.py

index 4dfa4e690a0bd8cc0813c5b9bde69ca0e7714810..553a5ae364152063391c04c6d879789664df205f 100755

--- a/tools/presubmit.py

+++ b/tools/presubmit.py

@@ -179,8 +179,7 @@ class SourceFileProcessor(object):

all_files = [

f.AbsoluteLocalPath()

for f in files

- if (os.path.isfile(f.AbsoluteLocalPath()) and

- not self.IgnoreFile(f.LocalPath()) and

+ if (not self.IgnoreFile(f.LocalPath()) and

self.IsRelevant(f.LocalPath()) and

all(not self.IgnoreDir(d) for d in dirs(f.LocalPath())) and

any(map(f.LocalPath().startswith, search_paths)))

« no previous file with comments | « PRESUBMIT.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698