Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2534813002: [test] Don't run presubmit over deleted files. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/presubmit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 0d5bb177db8d538c7bf65124b9380370979107e4..54adadb4af02659e16723adc101393f9ee6630c8 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -71,9 +71,11 @@ def _V8PresubmitChecks(input_api, output_api):
from presubmit import CheckStatusFiles
results = []
- if not CppLintProcessor().RunOnFiles(input_api.AffectedFiles()):
+ if not CppLintProcessor().RunOnFiles(
+ input_api.AffectedFiles(include_deletes=False)):
results.append(output_api.PresubmitError("C++ lint check failed"))
- if not SourceProcessor().RunOnFiles(input_api.AffectedFiles()):
+ if not SourceProcessor().RunOnFiles(
+ input_api.AffectedFiles(include_deletes=False)):
results.append(output_api.PresubmitError(
"Copyright header, trailing whitespaces and two empty lines " \
"between declarations check failed"))
« no previous file with comments | « no previous file | tools/presubmit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698