[Credit Card] Uses 4 dots in ellipsis

Uses 4 dots in ellipsis

BUG=670046
Committed: https://crrev.com/0f1b6446faadd346627671a384ea6a6aadba0d0e
Cr-Commit-Position: refs/heads/master@{#436440}

[csashi, 2016-12-02 21:10:09]

Description was changed from

==========
Uses 4 dots in ellipsis

BUG=670046
==========

to

==========
Uses 4 dots in ellipsis

BUG=670046
==========

[csashi, 2016-12-02 21:10:09]

csashi@google.com changed reviewers:
+ mathp@chromium.org

[csashi, 2016-12-02 21:10:30]

Hi Mathieu,
Can you take a look? Thanks.
-sashi.

[Mathieu, 2016-12-02 21:19:47]

lgtm

https://codereview.chromium.org/2534413006/diff/1/components/autofill/core/br...
File components/autofill/core/browser/personal_data_manager_unittest.cc (right):

https://codereview.chromium.org/2534413006/diff/1/components/autofill/core/br...
components/autofill/core/browser/personal_data_manager_unittest.cc:3701:
"\xE2\x80\xA2\xE2\x80\x86"
what about using base::string16(kMidlineEllipsis) in some capacity? Avoids the
ugliness somewhat

[Mathieu, 2016-12-02 21:19:54]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 21:20:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 00:00:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 00:00:54]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[csashi, 2016-12-03 01:02:30]

csashi@google.com changed reviewers:
+ rouslan@chromium.org, tedchoc@chromium.org

[csashi, 2016-12-03 01:02:30]

Hi Rouslan, Can you approve for
chrome/android/javatests/src/org/chromium/chrome/browser/payments

Hi Ted, Can you approve for
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/
Thanks,
-sashi.

https://codereview.chromium.org/2534413006/diff/1/components/autofill/core/br...
File components/autofill/core/browser/personal_data_manager_unittest.cc (right):

https://codereview.chromium.org/2534413006/diff/1/components/autofill/core/br...
components/autofill/core/browser/personal_data_manager_unittest.cc:3701:
"\xE2\x80\xA2\xE2\x80\x86"
On 2016/12/02 21:19:47, Mathieu Perreault wrote:
> what about using base::string16(kMidlineEllipsis) in some capacity? Avoids the
> ugliness somewhat

I assumed we intentionally did not want to reference kMidlineEllipsis in the
test. I defined an UTF8 string that I could reuse.

[please use gerrit instead, 2016-12-05 11:47:59]

lgtm

[Mathieu, 2016-12-05 16:50:39]

This is how it looks on desktop: 

https://drive.google.com/file/d/0B3xzZ-vFr2LRWVlZWjhUTTdyeTQ/view?usp=sharing

[csashi, 2016-12-05 17:09:30]

The CQ bit was checked by csashi@google.com

[csashi, 2016-12-05 17:09:30]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2534413006/#ps20001
(title: "Updates Java tests with new format for masked card numbers")

[commit-bot: I haz the power, 2016-12-05 17:09:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 17:17:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 17:17:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ted C, 2016-12-05 22:52:52]

On 2016/12/05 17:17:01, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
- lgtm

[csashi, 2016-12-05 22:57:07]

The CQ bit was checked by csashi@google.com

[commit-bot: I haz the power, 2016-12-05 22:57:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 23:04:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480978627329840,
"parent_rev": "6e41420081f5c4448f3d66ada24543a5b97f3246", "commit_rev":
"042d426c7e0ffc8b3dc85b7aff64ffbee6d29d36"}

[commit-bot: I haz the power, 2016-12-05 23:05:08]

Description was changed from

==========
Uses 4 dots in ellipsis

BUG=670046
==========

to

==========
Uses 4 dots in ellipsis

BUG=670046
==========

[commit-bot: I haz the power, 2016-12-05 23:05:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 23:07:45]

Description was changed from

==========
Uses 4 dots in ellipsis

BUG=670046
==========

to

==========
Uses 4 dots in ellipsis

BUG=670046

Committed: https://crrev.com/0f1b6446faadd346627671a384ea6a6aadba0d0e
Cr-Commit-Position: refs/heads/master@{#436440}
==========

[commit-bot: I haz the power, 2016-12-05 23:07:47]

Patchset 2 (id:??) landed as
https://crrev.com/0f1b6446faadd346627671a384ea6a6aadba0d0e
Cr-Commit-Position: refs/heads/master@{#436440}