[Credit Card] Uses 4 dots in ellipsis

components/autofill/core/browser/personal_data_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <list>
@@ skipping 3679 matching lines @@
 
   ASSERT_EQ(2U, personal_data_->GetCreditCards().size());
 
   // Sublabel is expiration date when filling card number. The second card
   // doesn't have a number so it should not be included in the suggestions.
   std::vector<Suggestion> suggestions =
       personal_data_->GetCreditCardSuggestions(
           AutofillType(CREDIT_CARD_NUMBER),
           /* field_contents= */ base::string16());
   ASSERT_EQ(1U, suggestions.size());
-  EXPECT_EQ(UTF8ToUTF16("Amex\xC2\xA0\xE2\x8B\xAF"
+  EXPECT_EQ(UTF8ToUTF16("Amex  "
+                        "\xE2\x80\xA2\xE2\x80\x86"

[Mathieu, 2016/12/02 21:19:47]

what about using base::string16(kMidlineEllipsis) in some capacity? Avoids the
ugliness somewhat

[csashi, 2016/12/03 01:02:30]

I assumed we intentionally did not want to reference kMidlineEllipsis in the
test. I defined an UTF8 string that I could reuse.

+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
                         "8555"),
             suggestions[0].value);
   EXPECT_EQ(ASCIIToUTF16("04/99"), suggestions[0].label);
 }
 
 // Tests the suggestions of duplicate local and server credit cards.
 TEST_F(PersonalDataManagerTest, GetCreditCardSuggestions_ServerDuplicates) {
   EnableWalletCardImport();
   SetupReferenceLocalCreditCards();
 
@@ skipping 43 matching lines @@
           /* field_contents= */ base::string16());
   ASSERT_EQ(4U, suggestions.size());
   EXPECT_EQ(ASCIIToUTF16("John Dillinger"), suggestions[0].value);
   EXPECT_EQ(ASCIIToUTF16("Clyde Barrow"), suggestions[1].value);
   EXPECT_EQ(ASCIIToUTF16("Bonnie Parker"), suggestions[2].value);
   EXPECT_EQ(ASCIIToUTF16("Bonnie Parker"), suggestions[3].value);
 
   suggestions = personal_data_->GetCreditCardSuggestions(
       AutofillType(CREDIT_CARD_NUMBER), /* field_contents= */ base::string16());
   ASSERT_EQ(4U, suggestions.size());
-  EXPECT_EQ(UTF8ToUTF16("Visa\xC2\xA0\xE2\x8B\xAF"
+  EXPECT_EQ(UTF8ToUTF16("Visa  "
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
                         "9012"),
             suggestions[0].value);
-  EXPECT_EQ(UTF8ToUTF16("Amex\xC2\xA0\xE2\x8B\xAF"
+  EXPECT_EQ(UTF8ToUTF16("Amex  "
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
                         "8555"),
             suggestions[1].value);
-  EXPECT_EQ(UTF8ToUTF16("MasterCard\xC2\xA0\xE2\x8B\xAF"
+  EXPECT_EQ(UTF8ToUTF16("MasterCard  "
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
                         "2109"),
             suggestions[2].value);
-  EXPECT_EQ(UTF8ToUTF16("Visa\xC2\xA0\xE2\x8B\xAF"
+  EXPECT_EQ(UTF8ToUTF16("Visa  "
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
+                        "\xE2\x80\xA2\xE2\x80\x86"
                         "2109"),
             suggestions[3].value);
 }
 
 // Tests that a full server card can be a dupe of more than one local card.
 TEST_F(PersonalDataManagerTest,
        GetCreditCardSuggestions_ServerCardDuplicateOfMultipleLocalCards) {
   EnableWalletCardImport();
   SetupReferenceLocalCreditCards();
 
@@ skipping 1594 matching lines @@
   EnableAutofillProfileCleanup();
 
   // The deduping routine should not be run.
   EXPECT_FALSE(personal_data_->ApplyDedupingRoutine());
 
   // The two duplicate profiles should still be present.
   EXPECT_EQ(2U, personal_data_->GetProfiles().size());
 }
 
 }  // namespace autofill