Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/core/browser/autofill_manager_unittest.cc

Issue 2534413006: [Credit Card] Uses 4 dots in ellipsis (Closed)
Patch Set: Updates Java tests with new format for masked card numbers Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndCardsTest.java ('k') | components/autofill/core/browser/credit_card.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_manager_unittest.cc
diff --git a/components/autofill/core/browser/autofill_manager_unittest.cc b/components/autofill/core/browser/autofill_manager_unittest.cc
index 5e5defcde77ae65ae155c13d391c317b1a8aa015..280a86dc218daac6ba329af803abe2fc83ec69fa 100644
--- a/components/autofill/core/browser/autofill_manager_unittest.cc
+++ b/components/autofill/core/browser/autofill_manager_unittest.cc
@@ -72,6 +72,13 @@ namespace {
const int kDefaultPageID = 137;
+const std::string kUTF8MidlineEllipsis =
+ " "
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86"
+ "\xE2\x80\xA2\xE2\x80\x86";
+
class MockAutofillClient : public TestAutofillClient {
public:
MockAutofillClient() {}
@@ -1439,14 +1446,11 @@ TEST_F(AutofillManagerTest, GetCreditCardSuggestions_EmptyValue) {
// Test that we sent the right values to the external delegate.
external_delegate_->CheckSuggestions(
- kDefaultPageID, Suggestion("Visa\xC2\xA0\xE2\x8B\xAF"
- "3456",
+ kDefaultPageID, Suggestion("Visa" + kUTF8MidlineEllipsis + "3456",
"04/99", kVisaCard,
autofill_manager_->GetPackedCreditCardID(4)),
- Suggestion("MasterCard\xC2\xA0\xE2\x8B\xAF"
- "8765",
- "10/98", kMasterCard,
- autofill_manager_->GetPackedCreditCardID(5)));
+ Suggestion("MasterCard" + kUTF8MidlineEllipsis + "8765", "10/98",
+ kMasterCard, autofill_manager_->GetPackedCreditCardID(5)));
}
// Test that we return all credit card profile suggestions when the triggering
@@ -1464,14 +1468,11 @@ TEST_F(AutofillManagerTest, GetCreditCardSuggestions_Whitespace) {
// Test that we sent the right values to the external delegate.
external_delegate_->CheckSuggestions(
- kDefaultPageID, Suggestion("Visa\xC2\xA0\xE2\x8B\xAF"
- "3456",
+ kDefaultPageID, Suggestion("Visa" + kUTF8MidlineEllipsis + "3456",
"04/99", kVisaCard,
autofill_manager_->GetPackedCreditCardID(4)),
- Suggestion("MasterCard\xC2\xA0\xE2\x8B\xAF"
- "8765",
- "10/98", kMasterCard,
- autofill_manager_->GetPackedCreditCardID(5)));
+ Suggestion("MasterCard" + kUTF8MidlineEllipsis + "8765", "10/98",
+ kMasterCard, autofill_manager_->GetPackedCreditCardID(5)));
}
// Test that we return all credit card profile suggestions when the triggering
@@ -1489,14 +1490,11 @@ TEST_F(AutofillManagerTest, GetCreditCardSuggestions_StopCharsOnly) {
// Test that we sent the right values to the external delegate.
external_delegate_->CheckSuggestions(
- kDefaultPageID, Suggestion("Visa\xC2\xA0\xE2\x8B\xAF"
- "3456",
+ kDefaultPageID, Suggestion("Visa" + kUTF8MidlineEllipsis + "3456",
"04/99", kVisaCard,
autofill_manager_->GetPackedCreditCardID(4)),
- Suggestion("MasterCard\xC2\xA0\xE2\x8B\xAF"
- "8765",
- "10/98", kMasterCard,
- autofill_manager_->GetPackedCreditCardID(5)));
+ Suggestion("MasterCard" + kUTF8MidlineEllipsis + "8765", "10/98",
+ kMasterCard, autofill_manager_->GetPackedCreditCardID(5)));
}
// Test that we return all credit card profile suggestions when the triggering
@@ -1523,8 +1521,7 @@ TEST_F(AutofillManagerTest, GetCreditCardSuggestions_StopCharsWithInput) {
// Test that we sent the right value to the external delegate.
external_delegate_->CheckSuggestions(
- kDefaultPageID, Suggestion("MasterCard\xC2\xA0\xE2\x8B\xAF"
- "3123",
+ kDefaultPageID, Suggestion("MasterCard" + kUTF8MidlineEllipsis + "3123",
"08/17", kMasterCard,
autofill_manager_->GetPackedCreditCardID(7)));
}
@@ -1544,8 +1541,7 @@ TEST_F(AutofillManagerTest, GetCreditCardSuggestions_MatchCharacter) {
// Test that we sent the right values to the external delegate.
external_delegate_->CheckSuggestions(
- kDefaultPageID, Suggestion("Visa\xC2\xA0\xE2\x8B\xAF"
- "3456",
+ kDefaultPageID, Suggestion("Visa" + kUTF8MidlineEllipsis + "3456",
"04/99", kVisaCard,
autofill_manager_->GetPackedCreditCardID(4)));
}
@@ -1563,15 +1559,13 @@ TEST_F(AutofillManagerTest, GetCreditCardSuggestions_NonCCNumber) {
GetAutofillSuggestions(form, field);
#if defined(OS_ANDROID)
- static const char* kVisaSuggestion =
- "Visa\xC2\xA0\xE2\x8B\xAF"
- "3456";
- static const char* kMcSuggestion =
- "MasterCard\xC2\xA0\xE2\x8B\xAF"
- "8765";
+ static const std::string kVisaSuggestion =
+ "Visa" + kUTF8MidlineEllipsis + "3456";
+ static const std::string kMcSuggestion =
+ "MasterCard" + kUTF8MidlineEllipsis + "8765";
#else
- static const char* kVisaSuggestion = "*3456";
- static const char* kMcSuggestion = "*8765";
+ static const std::string kVisaSuggestion = "*3456";
+ static const std::string kMcSuggestion = "*8765";
#endif
// Test that we sent the right values to the external delegate.
@@ -1659,14 +1653,11 @@ TEST_F(AutofillManagerTest,
// Test that we sent the right values to the external delegate.
external_delegate_->CheckSuggestions(
- kDefaultPageID, Suggestion("Visa\xC2\xA0\xE2\x8B\xAF"
- "3456",
+ kDefaultPageID, Suggestion("Visa" + kUTF8MidlineEllipsis + "3456",
"04/99", kVisaCard,
autofill_manager_->GetPackedCreditCardID(4)),
- Suggestion("MasterCard\xC2\xA0\xE2\x8B\xAF"
- "8765",
- "10/98", kMasterCard,
- autofill_manager_->GetPackedCreditCardID(5)));
+ Suggestion("MasterCard" + kUTF8MidlineEllipsis + "8765", "10/98",
+ kMasterCard, autofill_manager_->GetPackedCreditCardID(5)));
}
// Test that we will eventually return the credit card signin promo when there
@@ -1750,14 +1741,11 @@ TEST_F(AutofillManagerTest,
// Test that we sent the right values to the external delegate.
external_delegate_->CheckSuggestions(
- kDefaultPageID, Suggestion("Visa\xC2\xA0\xE2\x8B\xAF"
- "3456",
+ kDefaultPageID, Suggestion("Visa" + kUTF8MidlineEllipsis + "3456",
"04/99", kVisaCard,
autofill_manager_->GetPackedCreditCardID(4)),
- Suggestion("MasterCard\xC2\xA0\xE2\x8B\xAF"
- "8765",
- "10/98", kMasterCard,
- autofill_manager_->GetPackedCreditCardID(5)));
+ Suggestion("MasterCard" + kUTF8MidlineEllipsis + "8765", "10/98",
+ kMasterCard, autofill_manager_->GetPackedCreditCardID(5)));
}
// Test that we return credit card suggestions for secure pages that have a
@@ -1777,14 +1765,11 @@ TEST_F(AutofillManagerTest,
// Test that we sent the right values to the external delegate.
external_delegate_->CheckSuggestions(
- kDefaultPageID, Suggestion("Visa\xC2\xA0\xE2\x8B\xAF"
- "3456",
+ kDefaultPageID, Suggestion("Visa" + kUTF8MidlineEllipsis + "3456",
"04/99", kVisaCard,
autofill_manager_->GetPackedCreditCardID(4)),
- Suggestion("MasterCard\xC2\xA0\xE2\x8B\xAF"
- "8765",
- "10/98", kMasterCard,
- autofill_manager_->GetPackedCreditCardID(5)));
+ Suggestion("MasterCard" + kUTF8MidlineEllipsis + "8765", "10/98",
+ kMasterCard, autofill_manager_->GetPackedCreditCardID(5)));
}
// Test that we return all credit card suggestions in the case that two cards
@@ -1811,18 +1796,13 @@ TEST_F(AutofillManagerTest, GetCreditCardSuggestions_RepeatedObfuscatedNumber) {
// Test that we sent the right values to the external delegate.
external_delegate_->CheckSuggestions(
- kDefaultPageID, Suggestion("Visa\xC2\xA0\xE2\x8B\xAF"
- "3456",
+ kDefaultPageID, Suggestion("Visa" + kUTF8MidlineEllipsis + "3456",
"04/99", kVisaCard,
autofill_manager_->GetPackedCreditCardID(4)),
- Suggestion("MasterCard\xC2\xA0\xE2\x8B\xAF"
- "8765",
- "10/98", kMasterCard,
- autofill_manager_->GetPackedCreditCardID(5)),
- Suggestion("MasterCard\xC2\xA0\xE2\x8B\xAF"
- "3456",
- "05/99", kMasterCard,
- autofill_manager_->GetPackedCreditCardID(7)));
+ Suggestion("MasterCard" + kUTF8MidlineEllipsis + "8765", "10/98",
+ kMasterCard, autofill_manager_->GetPackedCreditCardID(5)),
+ Suggestion("MasterCard" + kUTF8MidlineEllipsis + "3456", "05/99",
+ kMasterCard, autofill_manager_->GetPackedCreditCardID(7)));
}
// Test that we return profile and credit card suggestions for combined forms.
@@ -1848,14 +1828,11 @@ TEST_F(AutofillManagerTest, GetAddressAndCreditCardSuggestions) {
// Test that we sent the credit card suggestions to the external delegate.
external_delegate_->CheckSuggestions(
- kPageID2, Suggestion("Visa\xC2\xA0\xE2\x8B\xAF"
- "3456",
+ kPageID2, Suggestion("Visa" + kUTF8MidlineEllipsis + "3456",
"04/99", kVisaCard,
autofill_manager_->GetPackedCreditCardID(4)),
- Suggestion("MasterCard\xC2\xA0\xE2\x8B\xAF"
- "8765",
- "10/98", kMasterCard,
- autofill_manager_->GetPackedCreditCardID(5)));
+ Suggestion("MasterCard" + kUTF8MidlineEllipsis + "8765", "10/98",
+ kMasterCard, autofill_manager_->GetPackedCreditCardID(5)));
}
// Test that for non-https forms with both address and credit card fields, we
@@ -4398,8 +4375,7 @@ TEST_F(AutofillManagerTest,
GetAutofillSuggestions(form, number_field);
external_delegate_->CheckSuggestions(
- kDefaultPageID, Suggestion("Visa\xC2\xA0\xE2\x8B\xAF"
- "3456",
+ kDefaultPageID, Suggestion("Visa" + kUTF8MidlineEllipsis + "3456",
"04/99", kVisaCard,
autofill_manager_->GetPackedCreditCardID(4)));
}
@@ -5183,11 +5159,10 @@ TEST_F(AutofillManagerTest, DisplayCreditCardSuggestionsWithMatchingTokens) {
GetAutofillSuggestions(form, field);
#if defined(OS_ANDROID)
- static const char* kVisaSuggestion =
- "Visa\xC2\xA0\xE2\x8B\xAF"
- "3456";
+ static const std::string kVisaSuggestion =
+ "Visa" + kUTF8MidlineEllipsis + "3456";
#else
- static const char* kVisaSuggestion = "*3456";
+ static const std::string kVisaSuggestion = "*3456";
#endif
external_delegate_->CheckSuggestions(
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndCardsTest.java ('k') | components/autofill/core/browser/credit_card.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698