Add infobar metrics for the new search geolocation disclosure.

Add infobar metrics for the new search geolocation disclosure.

The new metrics record the action the user took after the disclosure was
shown (ignored, clicked settings, or dismissed), as well as the time
that the infobar was shown for.

BUG=661011
Committed: https://crrev.com/e0c686cc741c804821070440dccbedad97ba848f
Cr-Commit-Position: refs/heads/master@{#435567}

[benwells, 2016-11-30 05:47:56]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 05:48:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[benwells, 2016-11-30 08:27:57]

Description was changed from

==========
Add infobar metrics for the new search geolocation diclosure.

The new metrics record the action the user took after the disclosure was
shown (ignored, clicked settings, or dismissed), as well as the time
that the infobar was shown for.

BUG=661011
==========

to

==========
Add infobar metrics for the new search geolocation disclosure.

The new metrics record the action the user took after the disclosure was
shown (ignored, clicked settings, or dismissed), as well as the time
that the infobar was shown for.

BUG=661011
==========

[benwells, 2016-11-30 08:29:47]

benwells@chromium.org changed reviewers:
+ dfalcantara@chromium.org, isherman@chromium.org

[benwells, 2016-11-30 08:29:47]

isherman for histograms
dfalcantara for the rest

[commit-bot: I haz the power, 2016-11-30 08:36:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 08:36:50]

Dry run: This issue passed the CQ dry run.

[gone, 2016-11-30 18:28:45]

lgtm

https://codereview.chromium.org/2534363002/diff/1/chrome/browser/android/sear...
File chrome/browser/android/search_geolocation_disclosure_infobar_delegate.cc
(right):

https://codereview.chromium.org/2534363002/diff/1/chrome/browser/android/sear...
chrome/browser/android/search_geolocation_disclosure_infobar_delegate.cc:25:
LAST = DISMISSED
Curious about this since I've seen it twice now: is using LAST = (whatever the
last legal value was) and then adding 1 preferable to just defining a COUNT
member (e.g. not adding = DISMISSED)?

[Ilya Sherman, 2016-12-01 00:50:49]

metrics lgtm (and +1 to Dan's question)

[benwells, 2016-12-01 04:04:48]

On 2016/12/01 00:50:49, Ilya Sherman wrote:
> metrics lgtm (and +1 to Dan's question)

[benwells, 2016-12-01 04:05:05]

On 2016/12/01 04:04:48, benwells (slow) wrote:
> On 2016/12/01 00:50:49, Ilya Sherman wrote:
> > metrics lgtm (and +1 to Dan's question)

Um ... I just copied something I've seen recently without really thinking about
it. I think I've seen both in the code base and don't really have any strong
preference. Since you're both asking I'll move this and the other one back.

[benwells, 2016-12-01 04:39:06]

On 2016/12/01 04:05:05, benwells (slow) wrote:
> On 2016/12/01 04:04:48, benwells (slow) wrote:
> > On 2016/12/01 00:50:49, Ilya Sherman wrote:
> > > metrics lgtm (and +1 to Dan's question)
> 
> Um ... I just copied something I've seen recently without really thinking
about
> it. I think I've seen both in the code base and don't really have any strong
> preference. Since you're both asking I'll move this and the other one back.

As I was changing them I remembered this being discussed before, so I dug up
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/zm_0_HwJCvk.

Seems like the initial consensus was to use COUNT, but some people prefer LAST
as it doesn't introduce valid enum values that shouldn't actually be used. I'll
still update to COUNT as it seems to be the consensus view.

[benwells, 2016-12-01 05:46:13]

The CQ bit was checked by benwells@chromium.org

[benwells, 2016-12-01 05:46:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2534363002/#ps20001
(title: "LAST -> COUNT")

[commit-bot: I haz the power, 2016-12-01 05:46:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 06:44:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480571173996620,
"parent_rev": "e0214e092c6d542ec041146131c50ad662b2765b", "commit_rev":
"8664ebd21eef652904dc994620437061adaac096"}

[commit-bot: I haz the power, 2016-12-01 06:45:14]

Description was changed from

==========
Add infobar metrics for the new search geolocation disclosure.

The new metrics record the action the user took after the disclosure was
shown (ignored, clicked settings, or dismissed), as well as the time
that the infobar was shown for.

BUG=661011
==========

to

==========
Add infobar metrics for the new search geolocation disclosure.

The new metrics record the action the user took after the disclosure was
shown (ignored, clicked settings, or dismissed), as well as the time
that the infobar was shown for.

BUG=661011
==========

[commit-bot: I haz the power, 2016-12-01 06:45:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-01 06:47:23]

Description was changed from

==========
Add infobar metrics for the new search geolocation disclosure.

The new metrics record the action the user took after the disclosure was
shown (ignored, clicked settings, or dismissed), as well as the time
that the infobar was shown for.

BUG=661011
==========

to

==========
Add infobar metrics for the new search geolocation disclosure.

The new metrics record the action the user took after the disclosure was
shown (ignored, clicked settings, or dismissed), as well as the time
that the infobar was shown for.

BUG=661011

Committed: https://crrev.com/e0c686cc741c804821070440dccbedad97ba848f
Cr-Commit-Position: refs/heads/master@{#435567}
==========

[commit-bot: I haz the power, 2016-12-01 06:47:24]

Patchset 2 (id:??) landed as
https://crrev.com/e0c686cc741c804821070440dccbedad97ba848f
Cr-Commit-Position: refs/heads/master@{#435567}