chrome/browser/ui/android/infobars/search_geolocation_disclosure_infobar.cc - Issue 2534363002: Add infobar metrics for the new search geolocation disclosure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/search_geolocation_disclosure_infobar.cc

Issue 2534363002: Add infobar metrics for the new search geolocation disclosure. (Closed)

Patch Set: LAST -> COUNT Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/search_geolocation_disclosure_infobar_delegate.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/search_geolocation_disclosure_infobar.cc

diff --git a/chrome/browser/ui/android/infobars/search_geolocation_disclosure_infobar.cc b/chrome/browser/ui/android/infobars/search_geolocation_disclosure_infobar.cc

index afb15bf0e4380948dc9e51c0c73aa7932e4a2538..f5da11ed31bbc7256dc57bee767fc9b34093e461 100644

--- a/chrome/browser/ui/android/infobars/search_geolocation_disclosure_infobar.cc

+++ b/chrome/browser/ui/android/infobars/search_geolocation_disclosure_infobar.cc

@@ -35,8 +35,7 @@ void SearchGeolocationDisclosureInfoBar::OnLinkClicked(

if (!owner())

return; // We're closing; don't call anything, it might access the owner.

- // This counts as a dismissed so the dialog isn't shown again.

- delegate()->InfoBarDismissed();

+ GetDelegate()->RecordSettingsClicked();

ScopedJavaLocalRef<jstring> search_url =

base::android::ConvertUTF8ToJavaString(