Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2842)

Unified Diff: chrome/browser/android/search_geolocation_disclosure_infobar_delegate.h

Issue 2534363002: Add infobar metrics for the new search geolocation disclosure. (Closed)
Patch Set: LAST -> COUNT Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/search_geolocation_disclosure_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/search_geolocation_disclosure_infobar_delegate.h
diff --git a/chrome/browser/android/search_geolocation_disclosure_infobar_delegate.h b/chrome/browser/android/search_geolocation_disclosure_infobar_delegate.h
index 72741dbb83d29c2aeddb4747f3dd25e0d8a94f36..e3a9cb060e46f7528b52d206e6779ac6b8e7b1ee 100644
--- a/chrome/browser/android/search_geolocation_disclosure_infobar_delegate.h
+++ b/chrome/browser/android/search_geolocation_disclosure_infobar_delegate.h
@@ -16,6 +16,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
+#include "base/time/time.h"
#include "build/build_config.h"
#include "components/infobars/core/infobar_delegate.h"
#include "ui/gfx/range/range.h"
@@ -40,6 +41,8 @@ class SearchGeolocationDisclosureInfoBarDelegate
static bool IsSearchGeolocationDisclosureOpen(
content::WebContents* web_contents);
+ void RecordSettingsClicked();
+
// The translated text of the message to display.
const base::string16& message_text() const { return message_text_; }
@@ -50,6 +53,8 @@ class SearchGeolocationDisclosureInfoBarDelegate
const GURL& search_url() const { return search_url_; }
private:
+ enum class DisclosureResult;
+
explicit SearchGeolocationDisclosureInfoBarDelegate(
content::WebContents* web_contents,
const GURL& search_url);
@@ -72,6 +77,12 @@ class SearchGeolocationDisclosureInfoBarDelegate
// The pref service to record prefs in.
PrefService* pref_service_;
+ // The result of showing the disclosure.
+ DisclosureResult result_;
+
+ // The time the infobar was created.
+ base::Time creation_time_;
+
DISALLOW_COPY_AND_ASSIGN(SearchGeolocationDisclosureInfoBarDelegate);
};
« no previous file with comments | « no previous file | chrome/browser/android/search_geolocation_disclosure_infobar_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698