Cleanup default FWL params part I

Cleanup default FWL params part I

This Cl removes some of the default FWL parameters.

Committed: https://pdfium.googlesource.com/pdfium/+/7fa190dbda7b3a5f46b8108aa7984b2fcc23d45c

[dsinclair, 2016-12-06 21:57:29]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 21:57:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-12-06 21:58:25]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-12-06 21:58:25]

PTAL.

[commit-bot: I haz the power, 2016-12-06 22:35:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 22:35:40]

Dry run: Try jobs failed on following builders:
  win_xfa_rel on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_rel/bui...)

[Tom Sepez, 2016-12-06 22:38:27]

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_edit.cpp
File xfa/fwl/core/cfwl_edit.cpp (right):

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_edit....
xfa/fwl/core/cfwl_edit.cpp:130: CFWL_Widget::SetStates(dwStates);
Sure this didn't ever used to do a RemoveStates equivalent?

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_form.cpp
File xfa/fwl/core/cfwl_form.cpp (right):

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_form....
xfa/fwl/core/cfwl_form.cpp:315: RemoveStates(FWL_WGTSTATE_Invisible);
Ooopsie.

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_pushb...
File xfa/fwl/core/cfwl_pushbutton.cpp (right):

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_pushb...
xfa/fwl/core/cfwl_pushbutton.cpp:54: void CFWL_PushButton::SetStates(uint32_t
dwStates) {
sure this never got called as false?

[dsinclair, 2016-12-07 15:03:27]

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_edit.cpp
File xfa/fwl/core/cfwl_edit.cpp (right):

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_edit....
xfa/fwl/core/cfwl_edit.cpp:130: CFWL_Widget::SetStates(dwStates);
On 2016/12/06 22:38:26, Tom Sepez wrote:
> Sure this didn't ever used to do a RemoveStates equivalent?

If we remove the Invisible or Disabled state, then they would have already been
set, so the cursor would already have been Hidden, no? So, Does false actually
do anything in this case other then proxy to CFWL_Widget::SetStates?

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_form.cpp
File xfa/fwl/core/cfwl_form.cpp (right):

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_form....
xfa/fwl/core/cfwl_form.cpp:315: RemoveStates(FWL_WGTSTATE_Invisible);
On 2016/12/06 22:38:26, Tom Sepez wrote:
> Ooopsie.

Done.

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_pushb...
File xfa/fwl/core/cfwl_pushbutton.cpp (right):

https://codereview.chromium.org/2533623002/diff/20001/xfa/fwl/core/cfwl_pushb...
xfa/fwl/core/cfwl_pushbutton.cpp:54: void CFWL_PushButton::SetStates(uint32_t
dwStates) {
On 2016/12/06 22:38:26, Tom Sepez wrote:
> sure this never got called as false?

That call would have been changed to a RemoveState at the call site. This code
doesn't do anything with a false other then proxy through to
CFWL_Widget::SetStates

[Tom Sepez, 2016-12-07 21:01:38]

lgtm

[dsinclair, 2016-12-08 01:13:23]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:13:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:23:28]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481159603212810,
"parent_rev": "919c0842b74d382e7ae60c85ff16642b646afbb9", "commit_rev":
"7fa190dbda7b3a5f46b8108aa7984b2fcc23d45c"}

[commit-bot: I haz the power, 2016-12-08 01:23:31]

Description was changed from

==========
Cleanup default FWL params part I

This Cl removes some of the default FWL parameters.
==========

to

==========
Cleanup default FWL params part I

This Cl removes some of the default FWL parameters.

Committed:
https://pdfium.googlesource.com/pdfium/+/7fa190dbda7b3a5f46b8108aa7984b2fcc23...
==========

[commit-bot: I haz the power, 2016-12-08 01:23:32]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/7fa190dbda7b3a5f46b8108aa7984b2fcc23...