Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2535623002: Cleanup caret show/hide code (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup caret show/hide code This CL splits the cursor code into specific show/hide methods to make it clearer what is happening at each point. Committed: https://pdfium.googlesource.com/pdfium/+/919c0842b74d382e7ae60c85ff16642b646afbb9

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -48 lines) Patch
M xfa/fwl/core/cfwl_caret.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/core/cfwl_caret.cpp View 1 chunk +9 lines, -5 lines 0 comments Download
M xfa/fwl/core/cfwl_comboedit.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_edit.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/core/cfwl_edit.cpp View 1 2 6 chunks +51 lines, -40 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
dsinclair
PTAL.
4 years ago (2016-12-06 21:56:05 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-12-06 22:42:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535623002/40001
4 years ago (2016-12-08 01:02:49 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-08 01:13:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/919c0842b74d382e7ae60c85ff16642b646a...

Powered by Google App Engine
This is Rietveld 408576698