Cleanup default FWL params part I

xfa/fwl/core/cfwl_form.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/core/cfwl_form.h"
 
 #include <utility>
 
@@ skipping 263 matching lines @@
 
   CFWL_NoteDriver* pDriver = pApp->GetNoteDriver();
   if (!pDriver)
     return nullptr;
 
   m_pNoteLoop = pdfium::MakeUnique<CFWL_NoteLoop>();
   m_pNoteLoop->SetMainForm(this);
 
   pDriver->PushNoteLoop(m_pNoteLoop.get());
   m_bDoModalFlag = true;
-  SetStates(FWL_WGTSTATE_Invisible, false);
+  RemoveStates(FWL_WGTSTATE_Invisible);
   pDriver->Run();
 
 #if _FX_OS_ != _FX_MACOSX_
   pDriver->PopNoteLoop();
 #endif
 
   m_pNoteLoop.reset();
   return nullptr;
 }
 
 void CFWL_Form::EndDoModal() {
   if (!m_pNoteLoop)
     return;
 
   m_bDoModalFlag = false;
 
 #if (_FX_OS_ == _FX_MACOSX_)
   m_pNoteLoop->EndModalLoop();
   const CFWL_App* pApp = GetOwnerApp();
   if (!pApp)
     return;
 
   CFWL_NoteDriver* pDriver =
       static_cast<CFWL_NoteDriver*>(pApp->GetNoteDriver());
   if (!pDriver)
     return;
 
   pDriver->PopNoteLoop();
-  SetStates(FWL_WGTSTATE_Invisible, true);
+  SetStates(FWL_WGTSTATE_Invisible);
 #else
-  SetStates(FWL_WGTSTATE_Invisible, true);
+  RemoveStates(FWL_WGTSTATE_Invisible);

[Tom Sepez, 2016/12/06 22:38:26]

Ooopsie.

[dsinclair, 2016/12/07 15:03:27]

Done.

   m_pNoteLoop->EndModalLoop();
 #endif
 }
 
 void CFWL_Form::DrawBackground(CFX_Graphics* pGraphics,
                                IFWL_ThemeProvider* pTheme) {
   CFWL_ThemeBackground param;
   param.m_pWidget = this;
   param.m_iPart = CFWL_Part::Background;
   param.m_pGraphics = pGraphics;
@@ skipping 304 matching lines @@
       HitTest(pMsg->m_fx, pMsg->m_fy) == FWL_WidgetHit::Titlebar) {
     if (m_bMaximized)
       SetWidgetRect(m_rtRestore);
     else
       SetWorkAreaRect();
 
     Update();
     m_bMaximized = !m_bMaximized;
   }
 }