Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2532763002: gpu: Cleanup class/struct forward declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Cleanup class/struct forward declarations Remove useless class and struct forward declarations, and add missing ones in gpu header files. BUG=662195 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/ed426734138853c695514585dc9c502da5f8af9d Cr-Commit-Position: refs/heads/master@{#434865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -69 lines) Patch
M gpu/command_buffer/client/client_test_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gpu_control.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/common/command_buffer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/common/command_buffer_mock.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/context_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/memory_program_cache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/transform_feedback_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/gles2_conform_support/egl/context.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/ipc/gl_in_process_context.h View 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/ipc/service/child_window_surface_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/service/gpu_channel_manager_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.h View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/ipc/service/image_transport_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/service/pass_through_image_transport_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/vulkan/vulkan_implementation.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jbriance
4 years ago (2016-11-25 22:06:13 UTC) #3
piman
lgtm
4 years ago (2016-11-28 23:10:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532763002/1
4 years ago (2016-11-28 23:45:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 03:22:06 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-29 03:23:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed426734138853c695514585dc9c502da5f8af9d
Cr-Commit-Position: refs/heads/master@{#434865}

Powered by Google App Engine
This is Rietveld 408576698